Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax signing constraint on marker transfer #261

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

iramiller
Copy link
Member

Description

Relaxes signing constraint on transfer operations for markers. Request must be signed by an administrator that possess transfer authority on the marker but the from account signature is no longer required. See #246 for discussion.

closes: #246


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@iramiller iramiller requested review from leeduan and a user April 22, 2021 16:46
@iramiller iramiller self-assigned this Apr 22, 2021
@iramiller iramiller added bug Something isn't working marker Marker Module security Security related request/issue labels Apr 22, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iramiller iramiller requested a review from arnabmitra April 22, 2021 16:52
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #261 (367b380) into main (03689b0) will increase coverage by 0.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   49.42%   49.83%   +0.41%     
==========================================
  Files         117      117              
  Lines       10564    10647      +83     
==========================================
+ Hits         5221     5306      +85     
+ Misses       4823     4820       -3     
- Partials      520      521       +1     
Impacted Files Coverage Δ
x/marker/types/msg.go 5.96% <0.00%> (+0.08%) ⬆️
x/metadata/types/specification.go 98.93% <0.00%> (-0.17%) ⬇️
x/attribute/types/keys.go 70.83% <0.00%> (+17.50%) ⬆️

@iramiller
Copy link
Member Author

Follow on issue opened for long term fix: #262

@iramiller iramiller merged commit ae49b6e into main Apr 22, 2021
@iramiller iramiller deleted the 246-update-transfer-behavior branch April 22, 2021 16:59
@iramiller iramiller restored the 246-update-transfer-behavior branch June 2, 2021 20:12
@iramiller iramiller deleted the 246-update-transfer-behavior branch June 2, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working marker Marker Module security Security related request/issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM Restricted Marker Transfer Question
3 participants