Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax signing constraint on marker transfer #261

Merged
merged 2 commits into from
Apr 22, 2021
Merged

relax signing constraint on marker transfer #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a281530
relax signing constraint on marker transfer
iramiller Apr 22, 2021
367b380
changelog
iramiller Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes
* Wired recovery flag into `init` command #254

### Client Breaking
* Update marker transfer request signing behavior #246

## [v1.1.1](https://github.com/provenance-io/provenance/releases/tag/v1.1.1) - 2021-04-15

### Bug Fixes
Expand Down
14 changes: 9 additions & 5 deletions x/marker/types/msg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,12 +501,16 @@ func (msg MsgTransferRequest) GetSigners() []sdk.AccAddress {
if err != nil {
panic(err)
}
sourceAddr, err := sdk.AccAddressFromBech32(msg.FromAddress)
if err != nil {
panic(err)
}
// NOTE: removed to support smart contract facilitated transfer of RESTRICTED_COIN marker coins.
// When SDK 0.43 authz support is available this constraint will be restored using grant based authorizations
// for transfer of funds. See https://github.com/provenance-io/provenance/issues/246

// sourceAddr, err := sdk.AccAddressFromBech32(msg.FromAddress)
// if err != nil {
// panic(err)
// }

return []sdk.AccAddress{adminAddr, sourceAddr}
return []sdk.AccAddress{adminAddr} // sourceAddr}
}

// NewSetDenomMetadataRequest creates a new marker in a proposed state with a given total supply a denomination
Expand Down