Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): solve errors in GCP services #5016

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

sergargar
Copy link
Member

@sergargar sergargar commented Sep 12, 2024

Description

Solve the following errors:

2024-09-12 15:05:50,026 [File: check.py:463] 	[Module: check]	 ERROR: apikeys_api_restrictions_configured -- KeyError[19]: 'apiTargets'

2024-09-12 15:06:25,196 [File: compute_service.py:297] 	[Module: compute_service]	 ERROR: TypeError[289]: Parameter "testService" value "" does not match the pattern "[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?|[1-9][0-9]{0,19}"

2024-09-12 15:06:51,094 [File: dns_service.py:40] 	[Module: dns_service]	 ERROR: KeyError[28]: 'dnssecConfig'

2024-09-12 15:07:54,558 [File: check.py:463] 	[Module: check]	 ERROR: kms_key_rotation_enabled -- ValueError[333]: time data '2025-07-06T22:00:00.561275Z' does not match format '%Y-%m-%dT%H:%M:%SZ'

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Sep 12, 2024
@sergargar
Copy link
Member Author

Pending to solve the error in check kms_key_rotation_enabled .

@sergargar sergargar added backport-to-v3 Backport PR to the v3 branch backport-to-v4.3 labels Sep 12, 2024
@sergargar sergargar marked this pull request as ready for review September 13, 2024 15:22
@sergargar sergargar requested review from a team as code owners September 13, 2024 15:22
pedrooot
pedrooot previously approved these changes Sep 20, 2024
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed fix, thanks!

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (65d7ba0) to head (b8e5c50).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../providers/gcp/services/compute/compute_service.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5016      +/-   ##
==========================================
+ Coverage   89.11%   89.13%   +0.01%     
==========================================
  Files         973      973              
  Lines       29816    29821       +5     
==========================================
+ Hits        26572    26580       +8     
+ Misses       3244     3241       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 16a2512 into master Sep 20, 2024
10 of 11 checks passed
@sergargar sergargar deleted the PRWLR-4834-solve-several-gcp-errors branch September 20, 2024 15:06
prowler-bot pushed a commit that referenced this pull request Sep 20, 2024
(cherry picked from commit 16a2512)

# Conflicts:
#	prowler/providers/gcp/services/kms/kms_key_rotation_enabled/kms_key_rotation_enabled.py
#	tests/providers/gcp/services/kms/kms_key_rotation_enabled/kms_key_rotation_enabled_test.py
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Sep 20, 2024
prowler-bot pushed a commit that referenced this pull request Sep 20, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch provider/gcp Issues/PRs related with the Google Cloud Platform provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants