-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gcp): solve errors in GCP services #5016
Conversation
Pending to solve the error in check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed fix, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5016 +/- ##
==========================================
+ Coverage 89.11% 89.13% +0.01%
==========================================
Files 973 973
Lines 29816 29821 +5
==========================================
+ Hits 26572 26580 +8
+ Misses 3244 3241 -3 ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 16a2512) # Conflicts: # prowler/providers/gcp/services/kms/kms_key_rotation_enabled/kms_key_rotation_enabled.py # tests/providers/gcp/services/kms/kms_key_rotation_enabled/kms_key_rotation_enabled_test.py
(cherry picked from commit 16a2512)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Description
Solve the following errors:
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.