Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): solve errors in GCP services #5124

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

prowler-bot
Copy link
Collaborator

Backport

This will backport the following commits from master to v4.3:

Questions ?

Please refer to the Backport tool documentation

@prowler-bot prowler-bot requested review from a team as code owners September 20, 2024 15:07
@prowler-bot prowler-bot added the backport This PR contains a backport label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (1dceed7) to head (2f72c37).
Report is 1 commits behind head on v4.3.

Files with missing lines Patch % Lines
.../providers/gcp/services/compute/compute_service.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v4.3    #5124      +/-   ##
==========================================
- Coverage   88.96%   88.94%   -0.03%     
==========================================
  Files         910      910              
  Lines       27756    27760       +4     
==========================================
- Hits        24694    24692       -2     
- Misses       3062     3068       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit 1f1165c into v4.3 Sep 20, 2024
8 of 10 checks passed
@MrCloudSec MrCloudSec deleted the backport/v4.3/pr-5016 branch September 20, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR contains a backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants