Skip to content

Add @martijneken and @mpwarres to CODEOWNERS #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mpwarres
Copy link
Contributor

No description provided.

Signed-off-by: Michael Warres <mpw@google.com>
@mpwarres mpwarres requested a review from martijneken April 26, 2024 17:46
@mpwarres mpwarres requested a review from PiotrSikora as a code owner April 26, 2024 17:46
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time! LGTM

@mpwarres mpwarres merged commit 284cd0b into proxy-wasm:master Apr 26, 2024
25 of 31 checks passed
@mpwarres mpwarres deleted the owners branch April 26, 2024 23:29
@PiotrSikora
Copy link
Member

Oops, this is actually in a wrong format. GitHub says that the format is valid (technically, it is...), but it should be:

* @PiotrSikora @martijneken @mpwarres

otherwise the last entry for * overwrites prior entries.

@martijneken
Copy link
Contributor

Sent #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants