Skip to content

fix: buildifier complaint #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

martijneken
Copy link
Contributor

No description provided.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Contributor Author

Seems like the code owner review is sticky to the randomly assigned reviewer. Would this be more flexible if we used a group, e.g. the maintainers group? https://github.com/orgs/proxy-wasm/teams/maintainers-c

@PiotrSikora
Copy link
Member

Seems like the code owner review is sticky to the randomly assigned reviewer. Would this be more flexible if we used a group, e.g. the maintainers group? https://github.com/orgs/proxy-wasm/teams/maintainers-c

That's not it, see: #392 (comment)

@martijneken martijneken merged commit 265e9d8 into proxy-wasm:master Apr 29, 2024
26 of 31 checks passed
@martijneken martijneken deleted the buildifier-fix branch April 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants