Chore: Update V8 flag initialization to use V8 API #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachel Green <rachgreen@google.com>
rachgreen33
changed the title
PiotrSikora
reviewed
Sep 16, 2025
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
rachgreen33
changed the title
Signed-off-by: Rachel Green <rachgreen@google.com>
rachgreen33
requested review from
leonm1,
martijneken and
mpwarres
as code owners
mpwarres
reviewed
Sep 17, 2025
Signed-off-by: Rachel Green <rachgreen@google.com>
mpwarres
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns with the V8 team's recommendation of setting flags this way through their API, rather than directly referencing v8::internal::v8_flags.