Skip to content

Chore: Update V8 flag initialization to use V8 API #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2025
Merged

Chore: Update V8 flag initialization to use V8 API #458

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9843a6
Set flags via the v8 API, instead of directly modifying them
rachgreen33 Sep 16, 2025
785835d
Merge branch 'main' into v8_flags_from_string
rachgreen33 Sep 16, 2025
fbec45d
Continue using the liftoff disable flag, but this time via the v8 API
rachgreen33 Sep 16, 2025
965ccd7
Fixed the includes statements.
rachgreen33 Sep 16, 2025
d1c7aa2
Fixed includes ordering.
rachgreen33 Sep 17, 2025
e061828
Added a comment explaining why we are disabling liftoff.
rachgreen33 Sep 17, 2025
c4b6d7e
Merge branch 'main' into v8_flags_from_string
rachgreen33 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/v8/v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
#include <utility>
#include <vector>

#include "include/proxy-wasm/limits.h"

#include "include/v8-version.h"
#include "include/v8.h"
#include "src/flags/flags.h"
#include "third_party/absl/strings/str_format.h"
#include "third_party/proxy_wasm_cpp_host/include/proxy-wasm/limits.h"
#include "third_party/v8/include/v8-initialization.h"
#include "src/wasm/c-api.h"
#include "wasm-api/wasm.hh"

Expand All @@ -42,10 +42,12 @@ wasm::Engine *engine() {
static wasm::own<wasm::Engine> engine;

std::call_once(init, []() {
::v8::internal::v8_flags.liftoff = false;
::v8::internal::v8_flags.wasm_max_mem_pages =
PROXY_WASM_HOST_MAX_WASM_MEMORY_SIZE_BYTES / PROXY_WASM_HOST_WASM_MEMORY_PAGE_SIZE_BYTES;
std::string args =
absl::StrFormat("--wasm_max_mem_pages=%u", PROXY_WASM_HOST_MAX_WASM_MEMORY_SIZE_BYTES /
PROXY_WASM_HOST_WASM_MEMORY_PAGE_SIZE_BYTES);
::v8::V8::SetFlagsFromString(args.c_str(), args.size());
::v8::V8::EnableWebAssemblyTrapHandler(true);

engine = wasm::Engine::make();
});

Expand Down
Loading