Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show filename after SD print finished #4821

Open
wants to merge 2 commits into
base: MK3
Choose a base branch
from
Open

Show filename after SD print finished #4821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9eaa95
Show filename after SD print finished
3d-gussner Dec 5, 2024
e427c4f
Fix lcd_status_message_level
3d-gussner Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Firmware/cmdqueue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,9 @@ void get_command()
sprintf_P(time, PSTR("%i hours %i minutes"),hours, minutes);
SERIAL_ECHO_START;
SERIAL_ECHOLN(time);
#ifndef SHOW_FILENAME_AFTER_FINISH
lcd_setstatus(time);
#endif //SHOW_FILENAME_AFTER_FINISH
card.printingHasFinished();
card.checkautostart(true);

Expand Down
6 changes: 5 additions & 1 deletion Firmware/ultralcd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,10 +542,14 @@ void lcdui_print_status_line(void) {
break;
}
}
else if ((IS_SD_PRINTING) &&
else if (((IS_SD_PRINTING) &&
(custom_message_type == CustomMsg::Status) &&
(lcd_status_message_level <= LCD_STATUS_INFO) &&
lcd_status_message_timeout.expired_cont(LCD_STATUS_INFO_TIMEOUT))
#ifdef SHOW_FILENAME_AFTER_FINISH
|| (GetPrinterState() == PrinterState::SDPrintingFinished)
gudnimg marked this conversation as resolved.
Show resolved Hide resolved
#endif //SHOW_FILENAME_AFTER_FINISH
)
{
// If printing from SD, show what we are printing
const char* longFilenameOLD = (card.longFilename[0] ? card.longFilename : card.filename);
Expand Down
7 changes: 7 additions & 0 deletions Firmware/variants/MK25-RAMBo10a.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,4 +520,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
3d-gussner marked this conversation as resolved.
Show resolved Hide resolved
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK25-RAMBo13a.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,4 +524,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK25S-RAMBo10a.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,4 +528,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK25S-RAMBo13a.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,4 +529,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK3-E3DREVO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,4 +687,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK3-E3DREVO_HF_60W.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,4 +688,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,4 +690,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK3S-E3DREVO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,4 +699,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK3S-E3DREVO_HF_60W.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,4 +700,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/MK3S.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,4 +702,11 @@
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/obsolete/1_75mm_MK2-RAMBo10a-E3Dv6full.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,4 +430,11 @@ THERMISTORS SETTINGS
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
7 changes: 7 additions & 0 deletions Firmware/variants/obsolete/1_75mm_MK2-RAMBo13a-E3Dv6full.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,4 +429,11 @@ THERMISTORS SETTINGS
#define DEFAULT_MIN_ARC_SEGMENTS 20 // The enforced minimum segments in a full circle of the same radius. Set to 0 to disable
#define DEFAULT_ARC_SEGMENTS_PER_SEC 0 // Use feedrate to choose segment length. Set to 0 to disable

/*------------------------------------
COMMUNITY FEATURES
*------------------------------------*/

//Show filename instead of print time after SD card print finished
//#define SHOW_FILENAME_AFTER_FINISH

#endif //__CONFIGURATION_PRUSA_H
Loading