Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show filename after SD print finished #4821

Open
wants to merge 2 commits into
base: MK3
Choose a base branch
from
Open

Show filename after SD print finished #4821

wants to merge 2 commits into from

Conversation

3d-gussner
Copy link
Collaborator

Adds the community option to show the printed filename instead of the printed time. Thanks for the suggestion #4107

To enable this community feature you need to un-comment #define SHOW_FILENAME_AFTER_FINISH in the variant file.

@3d-gussner 3d-gussner requested review from gudnimg and leptun December 16, 2024 17:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 247756 5654 6196 2538
MK3_MULTILANG 0 0 247126 5663 6826 2529

@sarusani sarusani mentioned this pull request Dec 21, 2024
Open
@3d-gussner 3d-gussner requested a review from sarusani December 23, 2024 07:14
gudnimg
gudnimg approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without testing. Code changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gudnimg gudnimg gudnimg approved these changes

@leptun leptun Awaiting requested review from leptun

@sarusani sarusani Awaiting requested review from sarusani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3d-gussner @gudnimg