Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lcd_menu_AutoLoadFilament #4763

Open
wants to merge 1 commit into
base: MK3
Choose a base branch
from

Conversation

sarusani
Copy link
Collaborator

@sarusani sarusani commented Aug 30, 2024

Added option to remove the "AutoLoad filament" LCD menu entry if autoload is enabled.
(#define REMOVE_AUTOLOAD_FILAMENT_MENU_ENTRY)

Saves 156 bytes of flash memory if enabled.

This will conflict with #4821. (I used the same "COMMUNITY FEATURES" header)
I will resolve the conflict after #4821 has been merged.

Copy link

github-actions bot commented Aug 30, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 2 0 247758 5654 6194 2538
MK3_MULTILANG 2 0 247128 5663 6824 2529

@gudnimg
Copy link
Collaborator

gudnimg commented Sep 3, 2024

@sarusani FYI theres a merge conflict now.

@sarusani sarusani force-pushed the RemoveLoadMenuOnAutoload branch 2 times, most recently from a5f86bf to 46110d3 Compare September 6, 2024 09:31
@sarusani sarusani force-pushed the RemoveLoadMenuOnAutoload branch from 46110d3 to 245b643 Compare November 20, 2024 11:58
Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sarusani sarusani force-pushed the RemoveLoadMenuOnAutoload branch from 245b643 to 927d264 Compare December 7, 2024 11:34
@3d-gussner
Copy link
Collaborator

@sarusani Please #ifdef this change, so we can keep it active, while the community can disable it if wanted.

Trying to think as a beginner this message still makes sense, but gets/seams "useless" information after a while.

@sarusani sarusani force-pushed the RemoveLoadMenuOnAutoload branch from 927d264 to a174b0f Compare December 21, 2024 11:44
@sarusani sarusani force-pushed the RemoveLoadMenuOnAutoload branch from a174b0f to 8e2a94d Compare December 21, 2024 11:51
@3d-gussner
Copy link
Collaborator

@gudnimg @sarusani Created sarusani#1 please review if you have time

@3d-gussner 3d-gussner requested a review from gudnimg December 24, 2024 07:03
Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants