IFNDEF more code that is releated to Filament Autoload #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnimg
reviewed
Dec 25, 2024
gudnimg
suggested changes
Dec 25, 2024
Comment on lines
+49
to
+52
| #ifndef REMOVE_AUTOLOAD_FILAMENT_MENU_ENTRY | ||
| void setAutoLoadEnabled(bool state, bool updateEEPROM = false); | ||
| bool getAutoLoadEnabled() const { return autoLoadEnabled; } | ||
| #endif //NOT REMOVE_AUTOLOAD_FILAMENT_MENU_ENTRY |
There was a problem hiding this comment.
I don't think this is the correct approach, you're disabling too much. These functions are not just used for the Autoload menu item. It's used by triggerFilamentInserted() too for normal autoload functionality.
There was a problem hiding this comment.
Actually these shouldn't be used when autoload is disabled. There in the 3rd commit I removed even more code and tested it with MK404
- MK3S
- MK3S + MMU
- MK2.5S
|
Nevertheless I will close this PR some of the Gonna keep the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.