Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appimage build process undocumented #1253

Open
jhoblitt opened this issue Sep 25, 2018 · 10 comments
Open

Appimage build process undocumented #1253

jhoblitt opened this issue Sep 25, 2018 · 10 comments

Comments

@jhoblitt
Copy link

The appimage build procedure appears to be undocumented/scripted within in this repo.

@jhoblitt
Copy link
Author

ping. This is a pretty major issue for linux devs that want to contribute.

@vojtechkral
Copy link
Contributor

vojtechkral commented Mar 27, 2019

I agree it would be nice to have appimage building done as part of the project.
I don't see how it's stopping you from contributing on Linux though, can you elaborate?

@jhoblitt
Copy link
Author

As there's no public CI, the build environment for a release needs to replicated as the dev env. Otherwise, there's no way to tell if a contribution will even compile in the release env. As an inverse example, I am able to build the current master on fedora 29 but it segfaults at start up. Is it because there's a different version of gcc, different tbb headers, etc.? I don't know and I don't want to have to debug it just for a simple contribution. Additionally, I do slicing on multiple different hosts and appimage is rather more convenient then having to build from source.

@probonopd
Copy link
Contributor

It would be nice if a system such as Travis CI would be used to produce the AppImage. I can help doing this if people would like.

@LongLiveCHIEF
Copy link

The original Slic3r had a package directory at the root of the project, and used travis to create the appimage. I suspect this project just removed that bit after forking, but the build is likely the same or similar.

@bubnikv
Copy link
Collaborator

bubnikv commented Feb 9, 2020

@LongLiveCHIEF

The original Slic3r had a package directory at the root of the project, and used travis to create the appimage. I suspect this project just removed that bit after forking, but the build is likely the same or similar.

Not true at all. PrusaSlicer was forked a lot earlier than that. To some extent we reuse the fruits of labor of each other. For example, the upstream slic3r was at its death bed 4 years ago because nobody was able to produce binary builds for all the pertinent platforms (slic3r-1.2.9 installers were built using Citrus Perl installer, which was long obsolete and it bundled old unstable UI libraries), until Prusa Researched hired and paid me to solve the binary distribution problem, which solution then has been adapted by the upstream slic3r. The draft of the CMake build system was provided by @craimer and finished by Prusa Research, then adopted by upstream slic3r. We at PrusaResearch are following the upstream development and we adopted most of their new C++ unit tests for example.

The upstream slic3r guys developed their travis build system long time after we had our internal build system. Our internal build system suits us well because it compiles quicker, which makes our continuous integration turnaround quicker than if using external servers.

@LongLiveCHIEF
Copy link

LongLiveCHIEF commented Feb 9, 2020 via email

@probonopd
Copy link
Contributor

In the meantime, you could extract the contents of the AppImage using --appimage-extract, make your changes, and repack the AppImage using https://github.com/AppImage/AppImageKit/releases/download/12/appimagetool-x86_64.AppImage.

@hradec
Copy link

hradec commented Mar 21, 2024

I have added a build script that uses docker container to build prusa slicer easier in any Linux distro and I've sent a pull request for it here: #12488

Unfortunately, I couldn't find any documentation or any build files required to create the appimage either (like the AppRun file, PrusaSlicer.png, etc).

It would be really amazing if I could just add the appimage build to this docker script too. (this docker script could be a starting point to use github actions to build, test and release nightly builds automatically)

So +1 on the appimage build documentation, please! :)

@wschadow
Copy link

for the appimage please see here #12383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants