Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include AppImage metadata #2732

Closed
goncalossilva opened this issue Aug 9, 2019 · 9 comments
Closed

Include AppImage metadata #2732

goncalossilva opened this issue Aug 9, 2019 · 9 comments

Comments

@goncalossilva
Copy link

goncalossilva commented Aug 9, 2019

Version

2.0.0

Operating system type + version

Linux / AppImage

Behavior

PrusaSlicer's basic AppImage support seems incomplete. There are a few key missing bits:

  1. Icon. If using appimaged, the app has no icon. I presume it is missing one in the correct location. Cura seems to handle this here, similar to other apps. Looking at Linux Appimage icon #451 it seems like this has worked at some point, but it's not showing for me on the latest version.
  2. File associations. Similarly, it is not automatically associated with *.stl and other supported files. Cura also does this well, which I presume is a combination of having a desktop file and installing it during compilation.

I would be happy to dig further into this and try to contribute, but the process is undocumented as discussed in #1253.

@bubnikv
Copy link
Collaborator

bubnikv commented Aug 19, 2019

The icon problem is likely caused by the following issue:
#1431 (comment)

@probonopd
Copy link
Contributor

probonopd commented Sep 21, 2019

Icon. If using appimaged, the app has no icon.

@goncalossilva please verify with the upcoming PrusaSlicer 2.1.0-beta.

File associations. Similarly, it is not automatically associated with *.stl and other supported files.

Cura has in its desktop file:

MimeType=model/stl;application/vnd.ms-3mfdocument;application/prs.wavefront-obj;image/bmp;image/gif;image/jpeg;image/png;text/x-gcode;application/x-amf;application/x-ply;application/x-ctm;model/vnd.collada+xml;model/gltf-binary;model/gltf+json;model/vnd.collada+xml+zip;

@bubnikv The PrusaSlicer 2.0.0 AppImage is lacking any MimeType= in its desktop file. Adding it there should do the trick.

@bubnikv
Copy link
Collaborator

bubnikv commented Sep 23, 2019 via email

@probonopd
Copy link
Contributor

The purpose of MimeType is not clear to me.

It allows the user to double-click, e.g., a .stl file, and it will be opened in PrusaSlicer.

@bubnikv
Copy link
Collaborator

bubnikv commented Sep 24, 2019

I was confused why Cura would want to register for image/bmp;image/gif;image/jpeg;image/png

@probonopd
Copy link
Contributor

Good question indeed. In fact I think it is not a good idea to do that.

@goncalossilva
Copy link
Author

There are quite a few discrepancies between what PrusaSlicer can open/import and what's in that list. This should probably be cleaned up and updated.

*.stl:

  • model/stl (official)
  • application/vnd.ms-pki.stl (also used)
  • application/pla (also used)

*.obj:

*.amf:

*.3mf:

I would suggest sticking with the "official" media types (except obj). That means PrusaSlicer would use:

MimeType=model/stl;text/prs.wavefront-obj;application/x-amf;model/3mf;application/vnd.ms-3mfdocument;

@bubnikv
Copy link
Collaborator

bubnikv commented Mar 20, 2020

I have updated the AppImage with
MimeType=model/stl;application/vnd.ms-3mfdocument;application/prs.wavefront-obj;application/x-amf;
from Cura. It will be contained in the PrusaSlicer 2.2.0 final.

Closing.

@bubnikv bubnikv closed this as completed Mar 20, 2020
@goncalossilva
Copy link
Author

goncalossilva commented Jun 8, 2020

Thanks @bubnikv! Borrowing from Cura is a great improvement. I don't know if you saw the comment above, but not all types are up-to-date, nor are Cura and PrusaSlicer completely on par in what they can open and import. A better list that's tailored specifically to PrusaSlicer is:

MimeType=model/stl;text/prs.wavefront-obj;application/x-amf;model/3mf;application/vnd.ms-3mfdocument;

I'd be happy to PR this but it doesn't look like it's OSS. The reasoning is 2 comments above this one, and I'm happy to discuss further if needed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants