Empty Genesis Validators Root Check in Slashing Protection Export (#9849

) * test for empty genesis validators root * precod * fix test Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
prysmaticlabs · Nov 3, 2021 · 4440ac1 · 4440ac1
1 parent d78428c
commit 4440ac1
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 1 deletion.
diff --git a/validator/rpc/slashing_test.go b/validator/rpc/slashing_test.go
@@ -112,6 +112,9 @@ func TestExportSlashingProtection_Preconditions(t *testing.T) {
 	defer func() {
 		require.NoError(t, validatorDB.Close())
 	}()
+	genesisValidatorsRoot := [32]byte{1}
+	err = validatorDB.SaveGenesisValidatorsRoot(ctx, genesisValidatorsRoot[:])
+	require.NoError(t, err)
 
 	_, err = s.ExportSlashingProtection(ctx, &empty.Empty{})
 	require.NoError(t, err)

diff --git a/validator/slashing-protection/local/standard-protection-format/export.go b/validator/slashing-protection/local/standard-protection-format/export.go
@@ -22,6 +22,11 @@ func ExportStandardProtectionJSON(ctx context.Context, validatorDB db.Database)
 	if err != nil {
 		return nil, errors.Wrap(err, "could not get genesis validators root from DB")
 	}
+	if genesisValidatorsRoot == nil || bytes.Equal(genesisValidatorsRoot, params.BeaconConfig().ZeroHash[:]) {
+		return nil, errors.New(
+			"genesis validators root is empty, perhaps you are not connected to your beacon node",
+		)
+	}
 	genesisRootHex, err := rootToHexString(genesisValidatorsRoot)
 	if err != nil {
 		return nil, errors.Wrap(err, "could not convert genesis validators root to hex string")

diff --git a/validator/slashing-protection/local/standard-protection-format/export_test.go b/validator/slashing-protection/local/standard-protection-format/export_test.go
@@ -12,6 +12,21 @@ import (
 	"github.com/prysmaticlabs/prysm/validator/slashing-protection/local/standard-protection-format/format"
 )
 
+func TestExportStandardProtectionJSON_EmptyGenesisRoot(t *testing.T) {
+	ctx := context.Background()
+	pubKeys := [][48]byte{
+		{1},
+	}
+	validatorDB := dbtest.SetupDB(t, pubKeys)
+	_, err := ExportStandardProtectionJSON(ctx, validatorDB)
+	require.ErrorContains(t, "genesis validators root is empty", err)
+	genesisValidatorsRoot := [32]byte{1}
+	err = validatorDB.SaveGenesisValidatorsRoot(ctx, genesisValidatorsRoot[:])
+	require.NoError(t, err)
+	_, err = ExportStandardProtectionJSON(ctx, validatorDB)
+	require.NoError(t, err)
+}
+
 func Test_getSignedAttestationsByPubKey(t *testing.T) {
 	t.Run("OK", func(t *testing.T) {
 		pubKeys := [][48]byte{

diff --git a/validator/slashing-protection/local/standard-protection-format/round_trip_test.go b/validator/slashing-protection/local/standard-protection-format/round_trip_test.go
@@ -86,7 +86,7 @@ func TestImportExport_RoundTrip_SkippedAttestationEpochs(t *testing.T) {
 			GenesisValidatorsRoot    string `json:"genesis_validators_root"`
 		}{
 			InterchangeFormatVersion: format.InterchangeFormatVersion,
-			GenesisValidatorsRoot:    fmt.Sprintf("%#x", [32]byte{}),
+			GenesisValidatorsRoot:    fmt.Sprintf("%#x", [32]byte{1}),
 		},
 		Data: []*format.ProtectionData{
 			{