Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prysm V3 General Wishlist #10322

Closed
3 of 4 tasks
rauljordan opened this issue Mar 8, 2022 · 14 comments
Closed
3 of 4 tasks

Prysm V3 General Wishlist #10322

rauljordan opened this issue Mar 8, 2022 · 14 comments

Comments

@rauljordan
Copy link
Contributor

rauljordan commented Mar 8, 2022

🚀 Feature Request

Description

"The Merge" will mark an important event for Prysm, as it is a good time to issue a Prysm "V3" containing any breaking changes we have been holding off from during Altair. This is a tracking issue for any desired changes from the team and the community.

Ideas

  • Deprecate the --http-web3provider flag to something more idiomatic. This will be the most important flag for the merge, as running an execution node is a requirement when participating in the Ethereum network
  • Delete all currently deprecated flags
  • Rename import paths to /v3/ to help with Go downstream imports
  • Rename all the fork-related protobufs from V1, V2, V3 to phase0, altair, bellatrix (relevant to the signing request protobufs)
@terencechain
Copy link
Member

  • Delete deprecated APIs. A bunch of prysm debug APIs that's never used and becoming hard to maintain over time (i.e get forkchoice nodes)
  • Revisit general logging. Some logs have useless fields and some logs miss important fields

@potuz
Copy link
Contributor

potuz commented Mar 8, 2022

@rkapka
Copy link
Contributor

rkapka commented Mar 8, 2022

Should we merge this with #10094?

@rauljordan
Copy link
Contributor Author

rauljordan commented Mar 8, 2022 via email

@rkapka
Copy link
Contributor

rkapka commented Mar 9, 2022

API

  • Use more idiomatic oneof and optionals for a cleaner schema
  • Change the SignedBeaconBlockContainerV2 to return a oneof type for SignedBeaconBlocks instead of having the signature as a separate field in the protobuf (this change is incompatible with Beacon APIs spec)
  • Standard API: remove v2 from all messages that are not request/responses (e.g. BeaconStateV2)
  • Prysm API: rename StreamBlocksAltair to StreamBlocks

@yorickdowne
Copy link
Contributor

yorickdowne commented Mar 25, 2022

  • Validator client: Support REST connection to consensus client. This would allow the Prysm validator client to be used in setups that use a diverse set of consensus clients, with the validator client having a list of three or more different consensus clients in its configuration.

@rauljordan
Copy link
Contributor Author

rauljordan commented Jun 28, 2022

  • Validator client: Support REST connection to consensus client. This would allow the Prysm validator client to be used in setups that use a diverse set of consensus clients, with the validator client having a list of three or more different consensus clients in its configuration.

Hi @yorickdowne , this task involves implementing a new validator client software entirely from scratch, completely different than the one we use today. We estimate this task would take at least half a year including testing and confidence boosting, as the Prysm validator client has been in production for years and is one of the riskiest pieces of our codebase. Having a brand new one incurs a lot of risk on stakers if not tested thoroughly. We have ruled this out in the short term, as it is unreasonable given our other priorities such as the merge and sharding

@rkapka
Copy link
Contributor

rkapka commented Jun 28, 2022

@rkapka
Copy link
Contributor

rkapka commented Jun 30, 2022

@nisdas
Copy link
Member

nisdas commented Jul 1, 2022

@rkapka This is already done in #10914

@james-prysm
Copy link
Contributor

james-prysm commented Jul 22, 2022

  • delete unused web APIs after switching to keymanager APIs

@nisdas
Copy link
Member

nisdas commented Jul 28, 2022

Feature Flags

Networking

@prestonvanloon
Copy link
Member

prestonvanloon commented Jul 29, 2022

@terencechain
Copy link
Member

Closing this. For the remaining items that we wish to carry to V4 (breaking changes only), we can open a separate issue for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants