Remove Deprecated Feature Flags #11125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Aug 12, 2022
| @@ -180,7 +180,5 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{ | |||
| // E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E. | |||
| var E2EBeaconChainFlags = []string{ | |||
| "--dev", | |||
| "--use-check-point-cache", | |||
There was a problem hiding this comment.
This is not present in deprecated_flags.go
There was a problem hiding this comment.
It hasn't been used in 2 years and the feature is a no-op currently. So it doesn't actually exist.
rkapka
previously approved these changes
Aug 12, 2022
rkapka
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
V3 Improvements
What does this PR do? Why is it needed?
In preparation for our v3 release, we remove all the deprecated feature flags here.
Which issues(s) does this PR fix?
Part of #10322
Other notes for review