Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Feature Flags #11125

Merged
merged 10 commits into from
Aug 14, 2022
Merged

Remove Deprecated Feature Flags #11125

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5db0f36
remove deprecated feature flags
nisdas Jul 28, 2022
ef97cc8
remove unused flags
nisdas Jul 28, 2022
317acff
Merge branch 'develop' into removeDeprecatedFeatFlags
nisdas Aug 12, 2022
2b2fd2c
Merge branch 'develop' into removeDeprecatedFeatFlags
nisdas Aug 12, 2022
ee2d225
remove other deprecated flags
nisdas Aug 12, 2022
54701bc
Merge refs/heads/develop into removeDeprecatedFeatFlags
prylabs-bulldozer[bot] Aug 12, 2022
dc3b1b9
remove native state flag
nisdas Aug 13, 2022
3bc4b7d
Merge remote-tracking branch 'origin/removeDeprecatedFeatFlags' into …
nisdas Aug 13, 2022
7faedd9
Merge refs/heads/develop into removeDeprecatedFeatFlags
prylabs-bulldozer[bot] Aug 13, 2022
42133ea
Merge refs/heads/develop into removeDeprecatedFeatFlags
prylabs-bulldozer[bot] Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 0 additions & 122 deletions config/features/deprecated_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,109 +12,6 @@ var (
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedEnableActiveBalanceCache = &cli.BoolFlag{
Name: "enable-active-balance-cache",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedCorrectlyPruneCanonicalAtts = &cli.BoolFlag{
Name: "correctly-prune-canonical-atts",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedCorrectlyInsertOrphanedAtts = &cli.BoolFlag{
Name: "correctly-insert-orphaned-atts",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedNextSlotStateCache = &cli.BoolFlag{
Name: "enable-next-slot-state-cache",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedEnableBatchGossipVerification = &cli.BoolFlag{
Name: "enable-batch-gossip-verification",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedEnableGetBlockOptimizations = &cli.BoolFlag{
Name: "enable-get-block-optimizations",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedEnableBalanceTrieComputation = &cli.BoolFlag{
Name: "enable-balance-trie-computation",
Usage: deprecatedUsage,
Hidden: true,
}

deprecatedDisableNextSlotStateCache = &cli.BoolFlag{
Name: "disable-next-slot-state-cache",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedAttestationAggregationStrategy = &cli.BoolFlag{
Name: "attestation-aggregation-strategy",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedForceOptMaxCoverAggregationStategy = &cli.BoolFlag{
Name: "attestation-aggregation-force-opt-maxcover",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedPyrmontTestnet = &cli.BoolFlag{
Name: "pyrmont",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableGetBlockOptimizations = &cli.BoolFlag{
Name: "disable-get-block-optimizations",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableProposerAttsSelectionUsingMaxCover = &cli.BoolFlag{
Name: "disable-proposer-atts-selection-using-max-cover",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableOptimizedBalanceUpdate = &cli.BoolFlag{
Name: "disable-optimized-balance-update",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableActiveBalanceCache = &cli.BoolFlag{
Name: "disable-active-balance-cache",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableBalanceTrieComputation = &cli.BoolFlag{
Name: "disable-balance-trie-computation",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableBatchGossipVerification = &cli.BoolFlag{
Name: "disable-batch-gossip-verification",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableCorrectlyPruneCanonicalAtts = &cli.BoolFlag{
Name: "disable-correctly-prune-canonical-atts",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedDisableCorrectlyInsertOrphanedAtts = &cli.BoolFlag{
Name: "disable-correctly-insert-orphaned-atts",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedEnableNativeState = &cli.BoolFlag{
Name: "enable-native-state",
Usage: deprecatedUsage,
Expand All @@ -139,25 +36,6 @@ var (

var deprecatedFlags = []cli.Flag{
exampleDeprecatedFeatureFlag,
deprecatedEnableActiveBalanceCache,
deprecatedCorrectlyPruneCanonicalAtts,
deprecatedCorrectlyInsertOrphanedAtts,
deprecatedNextSlotStateCache,
deprecatedEnableBatchGossipVerification,
deprecatedEnableGetBlockOptimizations,
deprecatedEnableBalanceTrieComputation,
deprecatedDisableNextSlotStateCache,
deprecatedAttestationAggregationStrategy,
deprecatedForceOptMaxCoverAggregationStategy,
deprecatedPyrmontTestnet,
deprecatedDisableProposerAttsSelectionUsingMaxCover,
deprecatedDisableGetBlockOptimizations,
deprecatedDisableOptimizedBalanceUpdate,
deprecatedDisableActiveBalanceCache,
deprecatedDisableBalanceTrieComputation,
deprecatedDisableBatchGossipVerification,
deprecatedDisableCorrectlyInsertOrphanedAtts,
deprecatedDisableCorrectlyPruneCanonicalAtts,
deprecatedEnableNativeState,
deprecatedEnablePeerScorer,
deprecatedEnableGossipBatchAggregation,
Expand Down
2 changes: 0 additions & 2 deletions config/features/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,5 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
// E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E.
var E2EBeaconChainFlags = []string{
"--dev",
"--use-check-point-cache",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not present in deprecated_flags.go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't been used in 2 years and the feature is a no-op currently. So it doesn't actually exist.

"--enable-active-balance-cache",
"--enable-native-state",
}