-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E refactoring: bootnode #8659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
Mar 24, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8659 +/- ##
===========================================
- Coverage 61.21% 61.20% -0.02%
===========================================
Files 493 494 +1
Lines 34296 34343 +47
===========================================
+ Hits 20996 21021 +25
- Misses 10169 10186 +17
- Partials 3131 3136 +5 |
This was referenced Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
ComponentRunner
interface is introduced: all components will have this interface, so within test spawning and waiting for component to fully start will be easier.components
package (we will not rely ont *testing.T
in components for logging)StartBootnode()
is moved into separateboot_node.go
file (originally we used beacon-node as a bootnode, but now have dedicated component, so it is abstracted in a separate file for consistency)boot_node.go
a new type is introduced, namelyBootNode
(it embedsComponentRunner
). Basically, this component has the very same code fromStartBootnode()
function, but abstracted within component interface. One major difference, to start the processexec.CommandContext()
is used instead ofexec.Command()
-- so, we can terminate running process at the end of the test.endtoend_test.go:runEndToEndTest()
-- this will be enabled in the last PR, which will updateendtoend_test.go
heavily to rely onerrgroup
and revamped components. Within that PR, component will be run as following (for details see E2E refactoring #8643 whereBootNode
is fully integrated):All nodes that depend on
BootNode
will be able to wait on itsstarted
channel (here is example of waiting for ETH1 node):Which issues(s) does this PR fix?
N/A
Other notes for review