Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beacon-state proto to new spec #1025

Merged
merged 4 commits into from
Dec 2, 2018

Conversation

prestonvanloon
Copy link
Member

Key changes here:

  • Sections of the proto have been assigned ID ranges such that when we need to add new fields to a section, they can continue a sequential ID pattern.
  • All of the fields of the BeaconState proto match the spec as of ethereum/consensus-specs@11d4473
  • I've moved all of the outdated/deprecated/renamed fields to a deprecated section of the proto and we can update these in the code incrementally.
  • Naming convention of bytes should suffix with their intended type if necessary. I.e. a hash32 should be in the form of field_name_hash32

Please confirm the rationale descriptions for deprecated fields.

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #1025 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
- Coverage    72.1%   72.05%   -0.05%     
==========================================
  Files          75       75              
  Lines        4595     4595              
==========================================
- Hits         3313     3311       -2     
- Misses        966      967       +1     
- Partials      316      317       +1

@prestonvanloon prestonvanloon merged commit 892357b into master Dec 2, 2018
@prestonvanloon
Copy link
Member Author

This is part of #781.

KimiWu123 pushed a commit to KimiWu123/prysm that referenced this pull request Dec 15, 2018
* update beacon-state proto to new spec

* AttestationData

* use bazel's pb.go

* boundry -> boundary
@nisdas nisdas deleted the update-beacon-state-proto branch January 28, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants