Update dependency com_github_go_stack_stack to v1 #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/com_github_go_stack_stack-1.x
branch
from
b390f5b
to
1f29f42
Compare
Codecov Report
@@ Coverage Diff @@
## master #1161 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 82 82
Lines 5158 5158
=======================================
Hits 3779 3779
Misses 1056 1056
Partials 323 323 |
nisdas
approved these changes
Dec 22, 2018
renovate
bot
force-pushed
the
renovate/com_github_go_stack_stack-1.x
branch
from
1f29f42
to
d2bbd11
Compare
prestonvanloon
pushed a commit
that referenced
this pull request
Dec 22, 2018
* first commit, remote att types * no more agg attestation proto * regen mock * only attestations * proto * att process * fix att references * more tests passing * use att protos * complete * Update dependency com_github_deckarep_golang_set to v1 (#1159) * Update dependency com_github_edsrzf_mmap_go to v1 (#1160) * Update dependency com_github_go_stack_stack to v1 (#1161) * Update dependency com_github_rs_cors to v1 (#1162) * Update dependency in_gopkg_urfave_cli_v1 to v1 (#1163) * change visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2fee6af->v1.8.0Release Notes
go-stack/stack
v1.8.0Compare Source
In addition to adding a go.mod file, this release also updates the implementation of the
%+sand%+vformats to provide semantically equivalent behavior when compiled in either a GOPATH or module based project. All existing tests still pass in both modes. Several cases of using this package in a module aware main program and with stacks that include modules >= v2.0.0 have been manually tested to ensure the results are useful in those cases.There is one subtle difference in the behavior when using modules. That is, stack frames originating in vendored packages built with the
-mod=vendorflag will report their import path as seen in the source code rather than a path in the vendor folder of the main project. Some may consider this an improvement—having paths that match the import path used in the source seems more natural—but opinions may differ here. Also note that the%#sand%#vformats still produce unmodified full paths to the compile time source locations as always.v1.7.0Compare Source
This release updates the implementation to use
runtime.CallersFramesto examine stack frame data. CallersFrames was added in Go 1.7, so this package no longer supports versions of Go prior to 1.7. If you need to use Go 1.6 or earlier, you should pin this package to v1.6.0.Go 1.9 changed the way stack data is returned from
runtime.Callers. The good news is that we can now see stack information for inlined functions. The bad news is that inspecting stack data is generally slower and requires more memory than before.v1.6.0Compare Source
This release adds the
%kformatting verb to output the package name for the function or method ofstack.Call. The unadorned verb outputs only the last segment of the package import path, while the%+kvariety produces the full import path of the package.Note that
%kwas chosen in part because one of this package's forks (https://github.com/getlantern/stack) had chosen it for the same purpose.%pwas considered, but thefmtpackage already uses that for formatting pointer values, and we wanted to avoid potential confusion with that use case.v1.5.4Compare Source
This release should fix several recent reports that some environments don't handle the intentional
nilpointer dereference used by this package to cache the address ofruntime.sigpanic. Caching the address ofruntime.sigpanicwas a performance optimization, sostack.Traceis slower in this release as shown by the benchmarks posted here: #12 (comment).But correctness takes priority over speed, so this release addresses correctness in the simplest way possible. A future release may be able to regain some of the lost performance.
An incomplete list of Issues in other projects that this release is intended to resolve:
v1.5.3Compare Source
v1.5.2Compare Source
v1.5.1Compare Source
v1.5.0Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.