Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Attestation Type Primitive With Proto Generated Type #1149

Merged
merged 19 commits into from
Dec 22, 2018

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Dec 20, 2018

This is part of #781

Description

This PR replaces all instances of primitives such as *types.Attestation with its corresponding proto pb.Attestation and pb.AttestationData and also as a Golang struct if they are mostly 1-to-1 (the Go structs only having getters and setters). As such, we will enforce using the proto generated types throughout the repo.

This PR deprecates all instances of AggregatedAttestation

@rauljordan rauljordan added Ready For Review A pull request ready for code review Priority: Low Low priority item labels Dec 22, 2018
@rauljordan rauljordan self-assigned this Dec 22, 2018
@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #1149 into master will decrease coverage by 0.61%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
- Coverage   73.26%   72.64%   -0.62%     
==========================================
  Files          82       82              
  Lines        5158     5111      -47     
==========================================
- Hits         3779     3713      -66     
- Misses       1056     1076      +20     
+ Partials      323      322       -1

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rauljordan
❌ renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More deletions than additions. My type of PR 😁
Looks good! Maybe mention you have deprecated AggregatedAtteststion proto in the description

@prestonvanloon prestonvanloon merged commit 1065617 into prysmaticlabs:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low priority item Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants