Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gogo protobuf as the protoc compiler #1165

Merged
merged 17 commits into from
Dec 23, 2018
Merged

Use gogo protobuf as the protoc compiler #1165

merged 17 commits into from
Dec 23, 2018

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Dec 22, 2018

Includes #1149 (already merged)

There are many benefits to gogo protobuf including:

  • fast marshalling and unmarshalling
  • more canonical Go structures
  • goprotobuf compatibility
  • less typing by optionally generating extra helper code
  • peace of mind by optionally generating test and benchmark code
  • other serialization formats

See more here:
github.com/gogo/protobuf

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b9a233d). Click here to learn what that means.
The diff coverage is 72.35%.

@@            Coverage Diff            @@
##             master    #1165   +/-   ##
=========================================
  Coverage          ?   72.56%           
=========================================
  Files             ?       82           
  Lines             ?     5117           
  Branches          ?        0           
=========================================
  Hits              ?     3713           
  Misses            ?     1080           
  Partials          ?      324

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@prestonvanloon prestonvanloon merged commit 10f4574 into master Dec 23, 2018
@nisdas nisdas deleted the gogoprotobuf branch January 28, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants