Add in Attestation Validity Check #6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
farazdagi
previously approved these changes
Aug 13, 2020
shayzluf
reviewed
Aug 13, 2020
…labs/geth-sharding into fixAttestationNoVerify
shayzluf
previously approved these changes
Aug 13, 2020
shayzluf
reviewed
Aug 13, 2020
| // the signature in that attestation. | ||
| func VerifyAttestation(ctx context.Context, beaconState *stateTrie.BeaconState, att *ethpb.Attestation) error { | ||
| if att == nil || att.Data == nil || att.AggregationBits.Count() == 0 { | ||
| return fmt.Errorf("nil or missing attestation data: %v", att) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("nil or missing attestation data: %v", att) | |
| return fmt.Errorf("nil, missing attestation data or no attesting indices: %v", att) |
terencechain
approved these changes
Aug 13, 2020
|
No , there was a valid indexed attestation check that was missing completely. It deviated from the spec and our old core methods. When changing it to batch verify attestations we missed this whole check. |
I see the `VerifyAttestation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review