-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidying up a few core functions #6995
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
+ Coverage 60.07% 62.41% +2.34%
==========================================
Files 323 402 +79
Lines 27422 31895 +4473
==========================================
+ Hits 16473 19907 +3434
- Misses 8733 9185 +452
- Partials 2216 2803 +587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep the voluntary exits(no verify), it is used for fuzzing that method. Otherwise with BLS the fuzzer will constantly fail.
I dont think we still use beacon fuzz do we? We switched to cluster fuzz. cc @prestonvanloon to confirm |
What type of PR is this?
What does this PR do? Why is it needed?
Further clean ups for #6986 and #6983. There's no functionality changes. Just deletion and renaming:
RemovedProcessVoluntaryExitsNoVerify
. It was only used for testsProcessVoluntaryExitsNoVerify
toProcessVoluntaryExitsNoVerifySignature
ProcessAttestationNoVerify
toProcessAttestationNoVerifySignature
VerifyAttestation
toVerifyAttestationSignature
. It makes the following b2b code more clearWhich issues(s) does this PR fix?
Fixes #
Other notes for review
CC @nisdas