Check that the headers are equal while ignoring the signature for proposer slashings #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…poser slashings. Resolves sigp/beacon-fuzz#74
prestonvanloon
added
Bug
…s/prysm into fix-proposer-slashing-issue
rauljordan
approved these changes
Sep 16, 2020
nisdas
reviewed
Sep 17, 2020
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| testutil.ResetCache() | ||
| if err := blocks.VerifyProposerSlashing(tt.args.beaconState, tt.args.slashing); (err != nil || tt.wantErr != "") && err.Error() != tt.wantErr { |
There was a problem hiding this comment.
we should use our assertion library over here
There was a problem hiding this comment.
Does the assertion library support this behavior?
I want: "if the test expects an error, assert the error is as expected"
There was a problem hiding this comment.
Not yet, it does have assert.ErrorContains which would be the closest to it. But yeah maybe not worth it to change now.
Codecov Report
@@ Coverage Diff @@
## master #7252 +/- ##
==========================================
- Coverage 60.07% 59.46% -0.61%
==========================================
Files 323 418 +95
Lines 27422 29941 +2519
==========================================
+ Hits 16473 17805 +1332
- Misses 8733 9231 +498
- Partials 2216 2905 +689 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
We had a minor spec deviation in checking proposer slashings.
Which issues(s) does this PR fix?
Fixes sigp/beacon-fuzz#74
Other notes for review
See sigp/beacon-fuzz#74 for more context.