Hide beacon operation field in log if it's 0 #8330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedmansour
previously approved these changes
Jan 25, 2021
beacon-chain/blockchain/log_test.go
Outdated
| }, | ||
| {name: "has attestation", | ||
| b: ðpb.BeaconBlock{Body: ðpb.BeaconBlockBody{Attestations: []*ethpb.Attestation{{}}}}, | ||
| want: "attestations=1", |
There was a problem hiding this comment.
This only tests if the string contains attestations, maybe we should add an additional test to make sure the other ones are not there.
|
This breaks scripts that rely on the fields existing. I don't really like to have the same log message have different log structure. If it's just a cosmetic change for the way it's printed then I think this should be applied only when the logger is stdout. Notice that if you log to journald, you can request only nonzero fields to be printed |
|
Updating target to v1.2.0 |
terencechain
added
Blocked
|
Hey @terencechain whats the status on this PR? |
terencechain
added
Ready For Review
and removed
Blocked
|
Ready. Let's target this for 1.3.0 |
rauljordan
approved these changes
Feb 18, 2021
prestonvanloon
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Hide displaying rest of the beacon fields if the count is 0
Which issues(s) does this PR fix?
Fixes # N/A
Other notes for review
Tried run time and it seems fine. Although non-attestations weren't involved...