Add timeSinceSlotStart field to "Synced new block..." log

[terencechain]

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Add

Which issues(s) does this PR fix?

Add timeSinceSlotStart field to "Synced new block..." log, this enhances debugging capability for both propagation issue and attesting issue.

Other notes for review

[rauljordan]

Super nice addition

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@ae028d9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #8420   +/-   ##
==========================================
  Coverage           ?   57.99%           
==========================================
  Files              ?      454           
  Lines              ?    32263           
  Branches           ?        0           
==========================================
  Hits               ?    18710           
  Misses             ?    10691           
  Partials           ?     2862           

[potuz]

Oh I am late hadn't seen this, I am sorry for being a pain in the ass but I think this is a bad addition. It is information that is currently included in the very same log message, so it adds size to the journal to get no new information. It only saves the viewer the time to do a subtraction and most users will not care about this info. The ones that do can do that subtraction.

It would be much more useful if we included a timeSinceBlockReceived log, this is new information that would be valuable diagnosing bad votes.

[terencechain]

Oh I am late hadn't seen this, I am sorry for being a pain in the ass but I think this is a bad addition. It is information that is currently included in the very same log message, so it adds size to the journal to get no new information. It only saves the viewer the time to do a subtraction and most users will not care about this info. The ones that do can do that subtraction.

It would be much more useful if we included a timeSinceBlockReceived log, this is new information that would be valuable diagnosing bad votes.

Its just one additional field per slot (few bytes), is the local storage really that expensive? Keep in mind that we'll remove 4 fields here:
#8330

Still a net gain after all. I personally prefer this than doing math in my head with the timestamp