Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert Optimized Balance Update Feature #9225

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jul 19, 2021

What type of PR is this?

Feature Flag Flip

What does this PR do? Why is it needed?

  • Inverts the optimized balance update flag. This allows for a more efficient calculation of validator balances that does
    reduce validator copies and therefore allocated heap usage.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner July 19, 2021 12:52
@nisdas nisdas requested review from prestonvanloon, terencechain and rkapka and removed request for a team July 19, 2021 12:52
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #9225 (ad67a10) into develop (15bfcf8) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff            @@
##           develop    #9225   +/-   ##
========================================
  Coverage    60.71%   60.72%           
========================================
  Files          545      545           
  Lines        39198    39199    +1     
========================================
+ Hits         23801    23805    +4     
+ Misses       11910    11905    -5     
- Partials      3487     3489    +2     

@prylabs-bulldozer prylabs-bulldozer bot merged commit dad205b into develop Jul 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the invertOptimizedBalanceUpdate branch July 19, 2021 14:27
prestonvanloon pushed a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants