Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert Optimized Balance Update Feature #9225

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Invert Optimized Balance Update Feature #9225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions shared/featureconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,10 @@ func ConfigureBeaconChain(ctx *cli.Context) {
log.WithField(disableProposerAttsSelectionUsingMaxCover.Name, disableProposerAttsSelectionUsingMaxCover.Usage).Warn(enabledFeatureFlag)
cfg.ProposerAttsSelectionUsingMaxCover = false
}
if ctx.Bool(enableOptimizedBalanceUpdate.Name) {
log.WithField(enableOptimizedBalanceUpdate.Name, enableOptimizedBalanceUpdate.Usage).Warn(enabledFeatureFlag)
cfg.EnableOptimizedBalanceUpdate = true
cfg.EnableOptimizedBalanceUpdate = true
if ctx.Bool(disableOptimizedBalanceUpdate.Name) {
log.WithField(disableOptimizedBalanceUpdate.Name, disableOptimizedBalanceUpdate.Usage).Warn(enabledFeatureFlag)
cfg.EnableOptimizedBalanceUpdate = false
}
Init(cfg)
}
Expand Down
6 changes: 6 additions & 0 deletions shared/featureconfig/deprecated_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ var (
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedEnableOptimizedBalanceUpdate = &cli.BoolFlag{
Name: "enable-optimized-balance-update",
Usage: deprecatedUsage,
Hidden: true,
}
)

var deprecatedFlags = []cli.Flag{
Expand All @@ -52,4 +57,5 @@ var deprecatedFlags = []cli.Flag{
deprecatedDisableEth1DataMajorityVote,
deprecatedDisableBlst,
deprecatedProposerAttsSelectionUsingMaxCover,
deprecatedEnableOptimizedBalanceUpdate,
}
9 changes: 4 additions & 5 deletions shared/featureconfig/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ var (
Name: "enable-slashing-protection-pruning",
Usage: "Enables the pruning of the validator client's slashing protectin database",
}
enableOptimizedBalanceUpdate = &cli.BoolFlag{
Name: "enable-optimized-balance-update",
Usage: "Enables the optimized method of updating validator balances.",
disableOptimizedBalanceUpdate = &cli.BoolFlag{
Name: "disable-optimized-balance-update",
Usage: "Disable the optimized method of updating validator balances.",
}
enableDoppelGangerProtection = &cli.BoolFlag{
Name: "enable-doppelganger",
Expand All @@ -136,7 +136,6 @@ var devModeFlags = []cli.Flag{
enableNextSlotStateCache,
forceOptMaxCoverAggregationStategy,
updateHeadTimely,
enableOptimizedBalanceUpdate,
}

// ValidatorFlags contains a list of all the feature flags that apply to the validator client.
Expand Down Expand Up @@ -188,7 +187,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
forceOptMaxCoverAggregationStategy,
updateHeadTimely,
disableProposerAttsSelectionUsingMaxCover,
enableOptimizedBalanceUpdate,
disableOptimizedBalanceUpdate,
}...)

// E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E.
Expand Down