include pump manufacturer and model in the pump status #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2019
ps2
added a commit
that referenced
this pull request
Jul 20, 2019
* Update to loopkit pumpmanager-updates * Avoid setting the alternateSegmentPulse flag for only one segment * Remove no-op store * Fix argument order * Fix rounding error when encoding half pulses into temp basal extra * Adding hex prints for full messages. * Finish BolusExtra command, and fix rounding error in Bolus command * Add test for large bolus * Fix another rounding issue with bolus schedule * Fix another likely rounding error for extended boluses * NNNN field in basal extra needs to be even multiple of 10 * Pulse rounding... - Allow rounding to 0.5 pulses for half hour segments of temp basals - Split up longer temp basals based on a limit of 6400 pulses max in an entry, and ensure that the rate for each entry rounds with 0.5 pulse accuracy * Cleanup * Persist faults in PodState, and display in issue report * Round request rate to nearest supported pod rate. * Round boluses to nearest pulse, and skip suspend during deactivation if pod is faulting * LoopKit PumpManagerStatus updates * Update LoopKit rev * Update set insulin command trigger delivery at half period intervals * PumpManagerUI vended HUD views * XXXXXXXX field is time remaining until next tenth of a pulse * Use LoopKit updates * LoopKit renaming * Many decoding fixes and added string formatting on PodInfoFaultEvent (#473) * Removed periods + created prefix * Moved prefix function into var description. Removed all hardcoded FaultEvent Type 0xXX from descriptions. * Added string variable for switch result to return together with generated fault code. * Return Unknown Error as a faultDescription variable * Code cleanup and removed duplicate FaultError string on Unknown Error * Renamed recieverLowGain->receiverLowGain * Renamed recieverLowGain->receiverLowGain Removed unused length enum * - Fixed proper encoding of bits for radioRSSI and receiverLowGain - Renamed receiverLowGain in IssueReport string * Be able to show negative RSSI and gain values by using an signed Integer. * Renamed Unknown Error Code -> Unknown Fault * Add missing rawType to testPumpAlarms assertion. * Add missing rawType to pass testPumpAlarm * Decode RSSI and Gain to Int8 values * index on omnipod-testing-podinfo-updates: 63086ef Add missing rawType to testPumpAlarms assertion. * Renamed swift file ReseroirStatus->PodProgressStatus * Decoding fixed for timeActive. * Fix failing Travis test: Renamed firstIndex -> index * Removed 'rawType' in assertion, to pass Travis test. * - Removed missed periods from faultevents - Added >50 U to reservoirLevel debugDescription - Removed unused function to parse time - Added switch statement for day/days * Updated PodInfotest to show String value for reservoirLevel * - Added FaultEvent description - Removed duplicate Status fields * Added new Faulteventcodes. * Updated FaultEvents with latest message.md values * Updated Loopkit in Cartfile.resolved to pass Travis build * Added description variable for showing names of DeliveryTypes in debugger instead of DeliveryType(rawValue:0) * - Removed whitespaces - Added enum for logEventErrorType to switch the different ErrorTypes instead of separate true/false evaluations. Still need to test if multiple ErrorTypes can be returned, no it assumes there can only be one. - Fixed missing last to bytes (YYYY) in encodedData PodInfoResponse - Added missing YYYY unknown Value - Renamed previousPodProgressStatus -> logEventErrorPodProgressStatus to let the PodProgressStatus be a part of the information about logged fault event - Renamed previousPodProgressStatusCheck -> previousPodProgressStatus * - Fixed seconds to minutes baseline for TimeInterval parsing - Parse minutes correctly to day/hour/minute integers - Renamed 'time since activation' strings to: 1 day plus 18:39 - Added tests to check proper string formatting for time debugger strings * Added missing 'plus' on time sting test * - Return nil for ReservoirLevel if it is not <50 U - Ensure new unknown logEventError values are printed properly. Setup logEventErrorType the same as faultEventType as a Model. This way it will return a value as a description or as an unknown code value. * Renamed index -> firstIndex back as it is setup in Data. Travis build error solved by updating from v9 to v10. * Unset all Development_team values in project. * Added Unit Test PodInfoFaultEvent: InsulinNotDelivered * Simplified the reservoirValue to read the decimal * podPulseSize And showing the value 50 as well. * - Fixed decoding only first 10 bits to count reservoirValue - Added StatusResponse test with 46U left. (real data capture) * Fixed typo unKnownValue->unknownValue * - Added hexadecimalString formatting to unknownvalue - Updated filename title of swift file to PodProgressStatus.swfit - Removed last development team value from project * Updated Cartfile.resolved to latest LoopKit to pass Travis * Add omnipod reservoir view * Update LoopKit rev * Adding pod life HUD view * Remove testing code * Bump loopkit rev * Adding missing file * Use actual basal schedule during time sync and pairing * Change alert name. belowFiftyUnits -> lowReservoir * Configurealarms beeprepeat fix and added back missing debugDescription values (#477) * - Fixed switched BeepRepeat <->BeepType encoding/decoding fields - Created enum for BeepRepeat to read more clearly what setting you will get - Fixed Tests to pass the enum values of BeepRepeat * Fixed failing podStateTests: added expiresAt value * Use the same Date instance on activatedAt and expiresAt parameters * Removed double entries in PodInfoFaultEvent description caused by rebasing * Added missing description values back to debugDescription * Replaced DeliveryType with DeliveryStatus to decode values like 0x06 * Updated to deliveryStatus types to pass tests * - Moved DeliveryStatus to Pod.swift because of it being a shared type. - Moved DeliveryType to cancelCommand because it is only applied there. - Removed DeliveryType description function because the options can be combined. - Rerouted DeliveryType in to cancelDeliveryCommand in PodCommsSession * Pod alarm handling * Update LoopKit reference * Add description for pod alarms * Comment out testing command for now * Omnipod testing pairing screen layout fixes (#478) * - Fixed cutoff text on 4s and 6 screen - Aligned footer text on all pages - Resized content boxes with constraint on margins * Aligned Filling Pod text to top left * Added 0x prefix to Fault en Log Code * Formatting for issue report * More issue report formatting updates * HUDProvider updates * Update loopkit rev * Update to Swift 4.2 * Fix reservoir update regression, and show hours floored for pod life remaining * Revert Storyboard changes from #478 * Use self sizing cells for omnipod pump setup * Updated FaultEventCodes from events.md commit be06014 back to e4d305c (#481) * Updated FaultEventCodes from events.md commit be06014 back to e4d305c * Upated cartfile.resolved * Use insulin remaining field of status resposne when canceling boluses. * Return DoseEntry for requested bolus, including duration * Add jumpstart pod method * Fix rounding issue with temp basals * Implement roundToDeliveryIncrement() for omnipod and minimed * Update loopkit rev * Add tests for delivery increments * Do not allow temp basal setting while bolus is in progress for omnipod. * Support multiple pumpmanager status observers * Use UIAlertController extension for error alerts * bump LoopKit rev * Basal schedule tests passing. * Basal schedule tests passing. * Fix BasalScheduleExtraCommand rate merging * Round current time to nearest second for calculation of fields in $13 command * Record message logs * Move OmnipodHUDProvider into its own module * Update LoopKit rev * Make OmnipodPumpManager persist between pod changes * Update LoopKit rev * Do not show PumpManager delete until pod is deactivated. * Update tests to use new PodState initializer * Setup mod podstate on simulator * Retry pod deactivation * Allow pairing on simulator * Track pairing state; only configure RL once during pairing * Handle pod pairing interruptions more atomically, pairing progress updates * Tweak retry params to closer match PDM * Handle faults during pairing * Fix tests * Forget pod immediately after deactivation, cancel doses on suspending fault * Experiments: * Set the A bit of B9 for the set basal schedule command during resume from suspend and during pairing * Advance nonce for each message send, instead of just successful message sends * Increment packet number for each packet exchange, instead of just successful exchanges. * $31 badMType -> insulinDeliveryCommandError * Shorter syncIdentifier for pumpevents * Do not make a status request before issuing a new temp basal, unless a bolus might be active. * $08 bit in the AX cancel byte is not cancel for extended boluses, and do not set it when cancelling all delivery * Handle RL responses with 0 length packets as just a bad packet instead of a more serious error * New understanding of flagA: expectFollowOnMessage. * Fix nonce resync. New packet parser * Fix nonce resync. New packet parser * Time formatting change for tests * Add omnipod packet parsing for loop issue report files * Forget podstate only after success or second failure. * Make PodCommsSession run synchronously; only used from OmnipodPumpManager's queue * Fix tests * Fix issue with basal sync when no pod is paired * Handle QQQQ of 0xFFFF for faultEventTimeSinceActivation * Make disabling x faults the default * Updates for LoopKit name changes * Fault Event and Issue Report updates (#488) * - Updated/Added new fault events up to commit 8bab297 of events.md - Updated IssueReport Faultevents with hex and total insulin delivered values - Updated PodInfoTest for new values * - Only prepend 0x hex for still unknown values, if decimal render without any. - Format reservoirLevel as String type only at display time - Single hex: type as Integer - Force 2 decimals on all insulin values - Updated Podinfo tests * Add additional setup state, after cannula insertion, before verification. * Alerts unify (#489) * AlertType + PodAlarm -> Alert * Add abstraction for assigning alerts to numbered slots on the pod * Register alerts with podstate * Fix alert slot serialization * Flip alert mask from msb first to lsb first * Revert alert bit order change, and fix expiration advisory alarm setup * Compute alarm timing based on fixed intervals since activation time * Test fixes * Fix totalInsulinDelivered decoding in faults * Updates for recent LoopKit pumpmanager-changes branch * Fix retain cycle * Persist message log * Bump loopkit rev * Handle LoopKit changes to setup indicator * Handle settings view controllers being presented modally * CompletionNotifying protocol updates * More changes for switch to modal presentation * MinimedPumpManager changes for PumpManager protocol updates * devicesSectionIndex is not changed after initialization * Bump LoopKit rev * Fix handling settings completion * Don't push root viewcontroller * Don't push root viewcontroller * Wrap unsuspend for bolus errors in SetBolusError.certain * Allow PumpState mock creation * Create suspend resume cell via cell reuse * Remove unused argument * Use higher res delivery for x23 pumps for roundToDeliveryIncrement * Guard access to MinimedPumpManagerState * Code organization * dequeue SuspendResumeTableViewCell * Remove unneeded conditional let * Fix typo * Make some properties immutable on MinimedPumpManagerState * Add notes about thread issues * Include dose in enactBolus completion * Dismiss settings controller on minimed pumpmanager delete * Bump LoopKit rev * Bump LoopKit rev * Setup controller is presented modally * Setup controller is shown modally * Update LoopKit rev * Add missing schemes * Show query date on pod reservoir * Fix insulin formatting * Disable timerTick when appropriate, loop based on bg arrival, and reduce number of status requests. * Avoid temp basal cancel and any status requests while bolusing. * Parse xcode logs for RL packets * ackUntilQuiet() should listen for packets with current pod address * Fix delay in alarm showing on reservoir view on startup. * Show pod settings when tapping on reservoir view * Fix alarm clearing UI updates * x23 pumps speed up bolus delivery to fit in 5 minute window * present instead of show settings vc * Remove zero bolus error; use assertionFailure instead * Fix vc present() call * ReservoirVolumeHUDView interface changed * Use active flag instead of appear/disapper methods * Update hud views only when active * Merge in latest from pumpmanager-changes * HUDProvider active -> visible * Update reservoir view on becoming active. * Fix travis build * Define allowed rates for x23 and x22 pumps, and integrate new basal picker * Define allowed rates for omnipod, and integrate new basal picker * Fix bug with tracking last temp basal * Add new pump precision methods required by PumpManager protocol * Add new pump precision methods required by PumpManager protocol * Report ongoing temp basal * Fix incorrect suspend state after changing time and basal schedule * Error when changing time zone or basal schedule while bolusing * Nonce resync is a certain failure while bolusing. * Refresh status when hud is made visible * Trackiong suspend PumpEvents * Track resume separately for InsulinMath reconciliation * omnipod pair/deactivate message edits (#502) * Show unfinalizedResume in issue report * Use previous, not current nonce, in nonce resync calculation * Record resume event for programming basal schedule * Nonce seed is 16 bit counter, and advance nonce after resync * Bolus progress integration * Add time offset for average comms delay * Fix suspend transitioning race * Update to latest LoopKit rev * Pre-build carthage * Replace pod command should only be red it is a destructive action * Update bolus state when bolus cancellation finishes * Subtract prime units from total insulin delivered * Add acknowledgeBeep Bool option for Pod insulin commands (#510) * Use only 32-bit math for nonce table as per firmware (#511) * Update fault codes and messages from firmware (#512) * Create suspend and resume events during pod replacement (#513) * Update wording on bolus in progress error * User configurable pod expiration warning * set initial expirationReminderDate after priming * Update the expiration reminder alert when settings is shown * On pod fault display Pod expired/Empty reservoir/Occlusion detected/fault code (#514) * On pod fault say Pod expired/Empty reservoir/Occlusion detected/hex code * Reworked to have PodReplacementReason.fault case contain the fault type * Have .fault case now store FaultEventCode, print miscellaneous fault values in decimal * Reworked to make rawType on FaultEventCode public so all pod faults can be simply printed, fix long-standing typo (setup -> set up) * Use faultCode.localizedDescription to provide the fault code description for the user * Deactive button should be red when deactivating functioning pod * If, during retry of cannula insertion, we detect that it is finished, continue without async wait * Update existing pod state with default expirationReminderDate * Beep Options confidenceReminder -> completionBeep (#519) * Fix tests * If pod acks in responsed to configure command, it is already configured. * Finalize doses when removing old pod state. * Set pumpManager for finish vc at end of first time pod setup * Use omnipod-testing LoopKit * Fix incorrectly reported error during deactivation of faulting pod. * Bump rev for LoopKit * include pump manufacturer and model in the pump status (#522) * Add BeepConfig command support, miscellaneous beep related cleanup (#524) * Add BeepConfig command support, miscelleous beep related cleanup * Changed byteType from UInt8 to BeepType, remove unneeded length, improved commenting * Fix command count check, commenting cleanup (#523) * Fix command count check, commenting cleanup * Fix another bad length check, miscellaneous comment and code fixes, remove wiki commands and duplicated type comments * Fixed a number of PodInfo length issues in commenting, checking and testing * Threading updates * Update carthage revisions * Pause progress circle when not visible * Add OmniKitTests to shared scheme * Update to Swift 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.