Omnipod testing integrate #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow rounding to 0.5 pulses for half hour segments of temp basals - Split up longer temp basals based on a limit of 6400 pulses max in an entry, and ensure that the rate for each entry rounds with 0.5 pulse accuracy
…if pod is faulting
…473) * Removed periods + created prefix * Moved prefix function into var description. Removed all hardcoded FaultEvent Type 0xXX from descriptions. * Added string variable for switch result to return together with generated fault code. * Return Unknown Error as a faultDescription variable * Code cleanup and removed duplicate FaultError string on Unknown Error * Renamed recieverLowGain->receiverLowGain * Renamed recieverLowGain->receiverLowGain Removed unused length enum * - Fixed proper encoding of bits for radioRSSI and receiverLowGain - Renamed receiverLowGain in IssueReport string * Be able to show negative RSSI and gain values by using an signed Integer. * Renamed Unknown Error Code -> Unknown Fault * Add missing rawType to testPumpAlarms assertion. * Add missing rawType to pass testPumpAlarm * Decode RSSI and Gain to Int8 values * index on omnipod-testing-podinfo-updates: 63086ef Add missing rawType to testPumpAlarms assertion. * Renamed swift file ReseroirStatus->PodProgressStatus * Decoding fixed for timeActive. * Fix failing Travis test: Renamed firstIndex -> index * Removed 'rawType' in assertion, to pass Travis test. * - Removed missed periods from faultevents - Added >50 U to reservoirLevel debugDescription - Removed unused function to parse time - Added switch statement for day/days * Updated PodInfotest to show String value for reservoirLevel * - Added FaultEvent description - Removed duplicate Status fields * Added new Faulteventcodes. * Updated FaultEvents with latest message.md values * Updated Loopkit in Cartfile.resolved to pass Travis build * Added description variable for showing names of DeliveryTypes in debugger instead of DeliveryType(rawValue:0) * - Removed whitespaces - Added enum for logEventErrorType to switch the different ErrorTypes instead of separate true/false evaluations. Still need to test if multiple ErrorTypes can be returned, no it assumes there can only be one. - Fixed missing last to bytes (YYYY) in encodedData PodInfoResponse - Added missing YYYY unknown Value - Renamed previousPodProgressStatus -> logEventErrorPodProgressStatus to let the PodProgressStatus be a part of the information about logged fault event - Renamed previousPodProgressStatusCheck -> previousPodProgressStatus * - Fixed seconds to minutes baseline for TimeInterval parsing - Parse minutes correctly to day/hour/minute integers - Renamed 'time since activation' strings to: 1 day plus 18:39 - Added tests to check proper string formatting for time debugger strings * Added missing 'plus' on time sting test * - Return nil for ReservoirLevel if it is not <50 U - Ensure new unknown logEventError values are printed properly. Setup logEventErrorType the same as faultEventType as a Model. This way it will return a value as a description or as an unknown code value. * Renamed index -> firstIndex back as it is setup in Data. Travis build error solved by updating from v9 to v10. * Unset all Development_team values in project. * Added Unit Test PodInfoFaultEvent: InsulinNotDelivered * Simplified the reservoirValue to read the decimal * podPulseSize And showing the value 50 as well. * - Fixed decoding only first 10 bits to count reservoirValue - Added StatusResponse test with 46U left. (real data capture) * Fixed typo unKnownValue->unknownValue * - Added hexadecimalString formatting to unknownvalue - Updated filename title of swift file to PodProgressStatus.swfit - Removed last development team value from project * Updated Cartfile.resolved to latest LoopKit to pass Travis
…ault code (#514) * On pod fault say Pod expired/Empty reservoir/Occlusion detected/hex code * Reworked to have PodReplacementReason.fault case contain the fault type * Have .fault case now store FaultEventCode, print miscellaneous fault values in decimal * Reworked to make rawType on FaultEventCode public so all pod faults can be simply printed, fix long-standing typo (setup -> set up) * Use faultCode.localizedDescription to provide the fault code description for the user
… continue without async wait
* Fix command count check, commenting cleanup * Fix another bad length check, miscellaneous comment and code fixes, remove wiki commands and duplicated type comments * Fixed a number of PodInfo length issues in commenting, checking and testing
Pause progress circle when not visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.