Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib JPEG improvements #71

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Lib JPEG improvements #71

merged 3 commits into from
Aug 2, 2021

Conversation

fjtrujy
Copy link
Member

@fjtrujy fjtrujy commented Aug 1, 2021

Description

This PR does 2 things:

  • Remove the custom libjpeg library created a decade ago, and use the lasted and better supported libjpeg-turbo without any additional change.
  • In order to make easier existents homebrew migrations, another library called libjpeg_addons has been created, offering "similar" functionality as the existing one.

I will create additionals PRs in gskit, OPL and wLE

Thanks

Copy link
Member

@rickgaiser rickgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a great improvement to switch to using libjpeg-turbo. Thanks!

But the addons library in general I would have preferred not existed. If applications use libjpeg-turbo directly, they have full control over it's capabilities. An "in between" library should not be needed. If added for compatibilty reasons only it's ok.

Perhaps comments can be added to indicate the library is for compatibility only, and the preferred way is to use libjpeg-turbo directly?

libjpeg_addons/include/libjpg_addons.h Outdated Show resolved Hide resolved
libjpeg_addons/src/libjpg_addons.c Outdated Show resolved Hide resolved
libjpeg_addons/src/libjpg_addons.c Outdated Show resolved Hide resolved
libjpeg_addons/src/libjpg_addons.c Outdated Show resolved Hide resolved
libjpeg_addons/src/libjpg_addons.c Outdated Show resolved Hide resolved
@fjtrujy fjtrujy force-pushed the master branch 2 times, most recently from c68d1fd to 08993ce Compare August 1, 2021 18:14
@fjtrujy
Copy link
Member Author

fjtrujy commented Aug 1, 2021

Hello @rickgaiser,

I understand all your comments, and they make totally sense, however nowadays every single SDK, also exposes some additional frameworks or tools to make developer life easier.

This is why having these functions in additional libraries, could be good for lazy developers that just look for an easy solution, otherwise, for instance, where you will expose a function to generate a screenshot in a jpg format?
Would remove the function from the ports and include it in every single app.....? I don't think so.

Anyway, I enforce, the idea that both OPL and wLE should use libjgp directly and use their own implementation, but it is up to them.

What do you think?

Thanks

libjpeg_ps2_addons/src/libjpg_ps2_addons.c Outdated Show resolved Hide resolved
@fjtrujy fjtrujy force-pushed the master branch 3 times, most recently from 511fc9c to ebddfa1 Compare August 1, 2021 22:34
@fjtrujy
Copy link
Member Author

fjtrujy commented Aug 1, 2021

@rickgaiser I will do an improvement in the ps2sdk for the screenshot functions, it is currently so weird, but I will do as a separate PR.

Thanks

@rickgaiser rickgaiser merged commit a9f52e7 into ps2dev:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants