-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib JPEG improvements #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a great improvement to switch to using libjpeg-turbo. Thanks!
But the addons library in general I would have preferred not existed. If applications use libjpeg-turbo directly, they have full control over it's capabilities. An "in between" library should not be needed. If added for compatibilty reasons only it's ok.
Perhaps comments can be added to indicate the library is for compatibility only, and the preferred way is to use libjpeg-turbo directly?
c68d1fd
to
08993ce
Compare
Hello @rickgaiser, I understand all your comments, and they make totally sense, however nowadays every single SDK, also exposes some additional frameworks or tools to make developer life easier. This is why having these functions in additional libraries, could be good for Anyway, I enforce, the idea that both What do you think? Thanks |
511fc9c
to
ebddfa1
Compare
@rickgaiser I will do an improvement in the Thanks |
Description
This PR does 2 things:
libjpeg
library created a decade ago, and use the lasted and better supportedlibjpeg-turbo
without any additional change.libjpeg_addons
has been created, offering "similar" functionality as the existing one.I will create additionals PRs in
gskit
,OPL
andwLE
Thanks