Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libjpg addons for loading JPEG files #62

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

fjtrujy
Copy link
Contributor

@fjtrujy fjtrujy commented Aug 1, 2021

Pull Request checklist

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the PS2SDK-ports
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

This PR just removes custom loading jpg files using now, the addons library created specifically for it.

This PR ps2dev/ps2sdk-ports#71 needs to be merged before continue

Thanks

Copy link
Member

@rickgaiser rickgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as with OPL:
I thought the libjpeg_addons was for compatibility, but it looks like a lot of changes are still needed. Why don't we use libjpeg-turbo directly in this case if we're already changing the code so much?

@fjtrujy
Copy link
Contributor Author

fjtrujy commented Aug 1, 2021

Well I actually just changed few lines of code, the rest is just indentation changes.
The main reason why I didn't keep same "contract" it is because it was crappy, and I decided to create something easy to use instead.

@uyjulian uyjulian merged commit 74675a0 into ps2homebrew:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants