Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.28.1 #6182

Merged
merged 1 commit into from
Jun 29, 2022
Merged

v2.28.1 #6182

merged 1 commit into from
Jun 29, 2022

Conversation

nateprewitt
Copy link
Member

2.28.1 (2022-06-29)

Improvements

Dependencies

@nateprewitt
Copy link
Member Author

I'm deferring the decisions on #6159 and #6167 until we see larger data points. They have 5 and 2 user engagements respectively which seems very low for the current 2.28.x adoption rate. For the time being, there are straight forward workarounds for both.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's ship it! :shipit:

@afriedma
Copy link

afriedma commented Nov 17, 2022

I'm deferring the decisions on #6159 and #6167 until we see larger data points. They have 5 and 2 user engagements respectively which seems very low for the current 2.28.x adoption rate. For the time being, there are straight forward workarounds for both.

Hi, what is the workaround for #6167? I am adding ":authority" and the request fails @nateprewitt

@nateprewitt
Copy link
Member Author

@afriedma please keep conversations constrained to relevant issues. I believe this was already answered in the other issue you commented on. If you're unfamiliar with PreparedRequests, you can find them in our documentation.

@psf psf locked as off-topic and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants