Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dependency with chardet>=3.0.2,<6 #6179

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update Dependency with chardet>=3.0.2,<6 #6179

merged 1 commit into from
Jun 28, 2022

Conversation

hswong3i
Copy link
Contributor

https://github.com/chardet/chardet/releases/tag/5.0.0 was released on 2022-06-25 with remove of Python 3.6 support, which also align with our Python > 3.6 requirement.

Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com

@nateprewitt
Copy link
Member

Thanks for the PR, @hswong3i. We’ll also need an update in the __init__.py for the version range. You can find an example here.

We’ll also need to do some quick manual regression testing to verify there isn’t anything substantially breaking in the major version.

@hswong3i
Update Dependency with chardet>=3.0.2,<6
09483ba 
https://github.com/chardet/chardet/releases/tag/5.0.0 was released on
2022-06-25 with remove of Python 3.6 support, which also align with our
Python > 3.6 requirement.

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@hswong3i
Copy link
Contributor Author

Thanks for the PR, @hswong3i. We’ll also need an update in the init.py for the version range. You can find an example here.

@nateprewitt thank you for your prompt reply, and I had also discover this when running GitLab CLI.

We’ll also need to do some quick manual regression testing to verify there isn’t anything substantially breaking in the major version.

As your reference, https://github.com/python-gitlab/python-gitlab/blob/main/setup.py using request, and I got following message before apply this PR:

/usr/lib/python3/dist-packages/requests/__init__.py:109: RequestsDependencyWarning: urllib3 (1.26.9) or c
hardet (5.0.0)/charset_normalizer (2.1.0) doesn't match a supported version!
  warnings.warn(

Now my re-packaged https://build.opensuse.org/package/show/home:alvistack/psf-requests-2.28.0 working fine with https://build.opensuse.org/package/show/home:alvistack/python-gitlab-python-gitlab-3.5.0 under Ubuntu 22.04 with Python 3.10.

@hswong3i
Copy link
Contributor Author

Result after running make and make ci: report.xml.txt

================================================ short test summary info =================================================
FAILED tests/test_requests.py::TestTimeout::test_connect_timeout[timeout0] - Failed: The connect() request should time ...
FAILED tests/test_requests.py::TestTimeout::test_connect_timeout[timeout1] - Failed: The connect() request should time ...
FAILED tests/test_requests.py::TestTimeout::test_total_timeout_connect[timeout0] - requests.exceptions.ReadTimeout: HTT...
FAILED tests/test_requests.py::TestTimeout::test_total_timeout_connect[timeout1] - requests.exceptions.ReadTimeout: HTT...
===================== 4 failed, 575 passed, 13 skipped, 1 xfailed, 24 warnings in 172.28s (0:02:52) ======================
make: *** [Makefile:8: ci] Error 1

nateprewitt
nateprewitt approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through some checks locally and our previous test benchmarks seem to match between the two. I think we can raise the version range here comfortably.

@nateprewitt nateprewitt merged commit 73793ce into psf:main Jun 28, 2022
@nateprewitt nateprewitt mentioned this pull request Jun 28, 2022
Closed
@hswong3i hswong3i deleted the chardet_lt_6 branch June 28, 2022 06:29
@teake teake mentioned this pull request Jun 28, 2022
Merged
5 tasks
@nateprewitt nateprewitt mentioned this pull request Jun 29, 2022
Merged
This was referenced Jun 30, 2022
Merged
Merged
@hswong3i hswong3i restored the chardet_lt_6 branch July 18, 2022 06:40
giordano added a commit to giordano/reframe that referenced this pull request Aug 26, 2022
@giordano
Bump version of requests in requirements.txt
dedd65f 
This makes `requests` compatible with `chardet` v5: psf/requests#6179
@giordano giordano mentioned this pull request Aug 26, 2022
Merged
@kimsin98 kimsin98 mentioned this pull request Sep 13, 2022
Merged
@mr-c mr-c mentioned this pull request Sep 16, 2022
Closed
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Dec 12, 2022
@hswong3i
alvistack/2.27.1
b54519d 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request May 22, 2023
@hswong3i
alvistack/2.27.1
95114d3 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 8, 2023
@hswong3i
alvistack/2.27.1
a74a4d9 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 9, 2023
@hswong3i
alvistack/2.27.1
16d2511 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 10, 2023
@hswong3i
alvistack/2.27.1
c0aa10d 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 10, 2023
@hswong3i
alvistack/2.27.1
d0f8845 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 10, 2023
@hswong3i
alvistack/2.27.1
6399e0e 
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hswong3i @nateprewitt