Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Bump version of requests in requirements.txt #2579

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

giordano
Copy link
Contributor

This makes requests compatible with chardet v5: psf/requests#6179

This makes `requests` compatible with `chardet` v5: psf/requests#6179
@giordano
Copy link
Contributor Author

giordano commented Aug 26, 2022

But chardet 5 removed support for Python 3.6: https://github.com/chardet/chardet/releases/tag/5.0.0. Sigh. Can we maybe allow both 2.27.1 and 2.28.1?

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

requirements.txt Outdated Show resolved Hide resolved
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
@teojgo
Copy link
Contributor

teojgo commented Aug 29, 2022

Ok to test

@codecov-commenter
Copy link

Codecov Report

Merging #2579 (7840245) into master (0463226) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2579   +/-   ##
=======================================
  Coverage   86.69%   86.70%           
=======================================
  Files          59       59           
  Lines       10827    10827           
=======================================
+ Hits         9387     9388    +1     
+ Misses       1440     1439    -1     
Impacted Files Coverage Δ
reframe/frontend/executors/policies.py 92.59% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vkarak vkarak changed the title Bump version of requests in requirements.txt [packaging] Bump version of requests in requirements.txt Aug 29, 2022
@teojgo
Copy link
Contributor

teojgo commented Aug 29, 2022

@jenkins-cscs retry daint

@teojgo teojgo merged commit bf053e1 into reframe-hpc:master Aug 29, 2022
@giordano giordano deleted the patch-1 branch August 29, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants