Checking aliases for contest results #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # packages/api/package.json
Co-authored-by: pshenmic <pshenmic@gmail.com>
vercel
bot
temporarily deployed
to
Preview – platform-explorer-mainnet
owl352
force-pushed
the
feat/contested
branch
from
07ac06f to
8126620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
At this moment we showing all aliases for identities, but that incorrect, because some aliases can fail in contest
Things done
DAPI.jsutils.js, which allows check if alias is contested and make him normalizedIdentitiesController.jsfor new logic with aliasesMainController.js, now we don't create a balance request within it, so we get an response faster and also updated search by dpns.package.jsonagain includes my forks for dapi