Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aliases with ContestedResourceVoteState #306

Merged
merged 38 commits into from
Nov 17, 2024
Merged

Aliases with ContestedResourceVoteState #306

merged 38 commits into from
Nov 17, 2024

Conversation

owl352
Copy link
Collaborator

@owl352 owl352 commented Nov 7, 2024 •
edited
Loading

Issue

For new design we need owner of transaction in api responses
Also we need aliases for identity based on contestedResourceVoteState

Things done

  • package.json again includes my forks for dapi
  • Implemented new method in DAPI.js
  • Implemented new method in utils.js, which allows check if alias is contested and make him normalized
  • Updated alghoritms for identities searches in IdentitiesController.js for new logic with aliases
  • Updated https://github.com/owl352/dapi-client and https://github.com/owl352/dapi-grpc
  • Added owner field in request and model for transactions in Main, Transactions and Identity controllers
  • Added trim for owner in transaction model
  • Added aliases for transactions in transaction controller
  • Improved main.spec.js
  • Updated tests
  • Updated Readme.md

#302 MERGED HERE

@owl352 owl352 added the backend Related to backend (API) label Nov 7, 2024
@owl352 owl352 self-assigned this Nov 7, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 9:00pm
platform-explorer-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 9:00pm

pshenmic
pshenmic requested changes Nov 17, 2024
View reviewed changes
packages/api/package.json Outdated Show resolved Hide resolved
packages/api/src/DAPI.js Outdated Show resolved Hide resolved
packages/api/src/DAPI.js Outdated Show resolved Hide resolved
packages/api/src/DAPI.js Show resolved Hide resolved
packages/api/src/DAPI.js Show resolved Hide resolved
packages/api/src/controllers/IdentitiesController.js Outdated Show resolved Hide resolved
packages/api/src/controllers/IdentitiesController.js Outdated Show resolved Hide resolved
packages/api/src/controllers/IdentitiesController.js Outdated Show resolved Hide resolved
packages/api/src/controllers/MainController.js Outdated Show resolved Hide resolved
packages/api/src/utils.js Outdated Show resolved Hide resolved
pshenmic
pshenmic requested changes Nov 17, 2024
View reviewed changes
packages/api/README.md Outdated Show resolved Hide resolved
packages/api/src/DAPI.js Outdated Show resolved Hide resolved
packages/api/src/constants.js Outdated Show resolved Hide resolved
pshenmic
pshenmic requested changes Nov 17, 2024
View reviewed changes
packages/api/src/dao/IdentitiesDAO.js Outdated Show resolved Hide resolved
packages/api/src/dao/IdentitiesDAO.js Outdated Show resolved Hide resolved
packages/api/src/models/Transaction.js Outdated Show resolved Hide resolved
pshenmic
pshenmic requested changes Nov 17, 2024
View reviewed changes
packages/api/src/utils.js Outdated Show resolved Hide resolved
@owl352 owl352 merged commit f6ef39c into master Nov 17, 2024
9 checks passed
@pshenmic pshenmic deleted the feat/transactions-owners branch November 17, 2024 21:02
@owl352 owl352 mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshenmic pshenmic pshenmic approved these changes

Assignees

@owl352 owl352

Labels
backend Related to backend (API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owl352 @pshenmic