fixes #133 #137
Merged
fixes #133 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is the result of the output of `yarn --integrity`. Rails' task assets:precompile runs an integrity check when it installs yarn packages and adds them to the yarn.lock file. Without this, the deployments fail because git sees changes to files in the repo at the destination. We need to remember to run `yarn --integrity` instead of just `yarn` in the future. Documentation must be updated. I am still a bit worried that this will cause problems in the future with killing deployments. If one of the yarn packages gets updated and the lock file isn't updated, then the deployment will bail.
banukutlu
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the result of the output of
yarn --integrity. Rails' task assets:precompile runs an integrity check when it installs yarn packages and adds them to the yarn.lock file. Without this, the deployments fail because git sees changes to files in the repo at the destination. We need to remember to runbundle exec webpacker:yarn_installinstead of justyarnin the future. Documentation must be updated.I am still a bit worried that this will cause problems in the future with killing deployments. If one of the yarn packages gets updated and the lock file isn't updated, then the deployment will bail.