Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #133 #137

Merged
merged 2 commits into from
Oct 17, 2018
Merged

fixes #133 #137

merged 2 commits into from
Oct 17, 2018

Commits on Oct 17, 2018

  1. fixes #133 

    This change is the result of the output of `yarn --integrity`. Rails' task assets:precompile runs an integrity check when it installs yarn packages and adds them to the yarn.lock file. Without this, the deployments fail because git sees changes to files in the repo at the destination. We need to remember to run `yarn --integrity` instead of just `yarn` in the future. Documentation must be updated.

I am still a bit worried that this will cause problems in the future with killing deployments. If one of the yarn packages gets updated and the lock file isn't updated, then the deployment will bail.
    Charlie Morris committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    3c1b79d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into #136-yarn-integrity

    Banu Hapeloglu Kutlu authored Oct 17, 2018
    Configuration menu
    Copy the full SHA
    930e22d View commit details
    Browse the repository at this point in the history