Collection of bug reports/input from Mapping Fellows

[jywarren]

Our Mapping Fellows (https://publiclab.org/tag/community-atlas) had a call today and we're reporting in a collection of UI/UX input from them here -- very helpful! Thanks Sairam and Mo!

I've separated these out into issues for Leaflet.DistortableImage and MapKnitter. The matching MapKnitter issue is at publiclab/mapknitter#720

• It was hard to tell that the Xs mean "locked" -- seemed ambiguous or unexplained
• could we show the lock button depressed while it's locked?
• could we show a tooltip over the X handles that says Locked or Image is locked?
• Mo found that the button that seemed to make sense was "rotate" but that didn't override the lock. Perhaps we should ensure that clicking rotate/scale/distort unlocks the image automatically.

Also aggregating open issues here that will address the updates requested by Mo in https://publiclab.org/notes/molangmuir10/06-10-2019/mapknitter-ui-evaluation?_=1560394957

• Get the transparency tool to work on a range Get the transparency tool to work on a range #311

[sashadev-sky]

@jywarren for "Mo found that the button that seemed to make sense was "rotate" but that didn't override the lock. Perhaps we should ensure that clicking rotate/scale/distort unlocks the image automatically."

I implemented the specific opposite where locked can only be overridden by unlocked. To me it made sense because what is lock really doing if it any other key overrides it. Maybe it would be more clear once we make toolbar updates to make it more dynamic, and we can remove tools like "rotate", etc. when its in lock mode. Then if the user unlocks put them back? What are your thoughts?

If you have mo's email I can also reach out to him directly!

[jywarren]

Hi! I had followed your reasoning and agreed with it, but on talking with Mo, i saw more clearly how it was easy to miss that the image was locked, if you aren't familiar with the UI. The X icons don't mean "locked" to everyone - so that's one reason I suggested using tooltips there. But also, on hearing from Mo, I was persuaded that requiring an extra step (lock /then/ rotate) makes it more difficult to use - Mo was stuck entirely.

To me it made sense because what is lock really doing if it any other key

overrides it. I hear you on this, but you could say that it prevents the image from being moved accidentally -- if it's not locked, then shouldn't dragging it (even when unselected) be possible? Or have we made it necessary to select an image by clicking it /before/ you can drag it, and is that 2-step necessary and intuitive? Maybe you're right we should hear more from Mo on the issue! She's posted on the 'community-atlas' topic: https://publiclab.org/tag/community-atlas and this is probably the best place -- https://publiclab.org/notes/molangmuir10/06-10-2019/mapknitter-ui-evaluation Hope that helps, thanks so much!!!!

…

On Mon, Jun 24, 2019 at 5:24 PM Sasha Boginsky ***@***.***> wrote: @jywarren <https://github.com/jywarren> for "Mo found that the button that seemed to make sense was "rotate" but that didn't override the lock. Perhaps we should ensure that clicking rotate/scale/distort unlocks the image automatically." I implemented the specific opposite where locked can only be overridden by unlocked. To me it made sense because what is lock really doing if it any other key overrides it. Maybe it would be more clear once we make toolbar updates to make it more dynamic, and we can remove tools like "rotate", etc. when its in lock mode. Then if the user unlocks put them back? What are your thoughts? If you have mo's email I can also reach out to him directly! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#306?email_source=notifications&email_token=AAAF6J3YBFOYAN4WTLB53DTP4E3QJA5CNFSM4HZBMM22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYOIYKI#issuecomment-505187369>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J36YE437L3ZG4KBWRDP4E3QJANCNFSM4HZBMM2Q> .

[sashadev-sky]

@jywarren okay I think that makes sense too. I don't think its a big change either way so if Mo prefers the mode to be changable in a 1-step process then I'll make that happen. i'll open a PR that takes all of these into account at once to try and make it more intuitive and get yours and Mo's input!

[jywarren]

Thanks so much Sasha! You're so thorough!!!!!!

…

On Mon, Jun 24, 2019 at 6:42 PM Sasha Boginsky ***@***.***> wrote: @jywarren <https://github.com/jywarren> okay I think that makes sense too. I don't think its a big change either way so if Mo prefers the mode to be changable in a 1-step process then I'll make that happen. i'll open a PR that takes all of these into account at once to try and make it more intuitive and get yours and Mo's input! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#306?email_source=notifications&email_token=AAAF6JZEK4DL7DDL6UPCK7LP4FERFA5CNFSM4HZBMM22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYON3HQ#issuecomment-505208222>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J7D33MLASUXTGRGWBDP4FERFANCNFSM4HZBMM2Q> .

[rexagod]

Working on the above issues! Thanks all!