Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock mode tooltips #482

Merged
merged 10 commits into from
Jan 9, 2020
Merged

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Dec 22, 2019

References #306 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

===============

  • bump to 0.9.0
  • fix rest of linting
  • small refactoring
    ===============

@sashadev-sky
Copy link
Member Author

@jywarren pulled out more code from #442. please review when you can!
lock

@jywarren
Copy link
Member

jywarren commented Jan 3, 2020

This looks great, and once the conflict is resolved we can merge it!

@sashadev-sky
Copy link
Member Author

@jywarren ok great! I refactored and removed the tooltip from the image itself but other than that the result is the same as the gif

@sashadev-sky sashadev-sky merged commit 1b8dea3 into publiclab:main Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants