Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grunt-contrib-watch from 0.6.1 to 1.1.0 #174

Merged
merged 2 commits into from
Jan 1, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 7, 2018

Bumps grunt-contrib-watch from 0.6.1 to 1.1.0.

Changelog

Sourced from grunt-contrib-watch's changelog.

v1.1.0:
date: 2018-05-12
changes:
- Update to tiny-lr@1.1.1, lodash@4.17.10, async@2.6.0
v1.0.1:
date: 2018-04-20
changes:
- Update to gaze@1.1, lodash@4
v1.0.0:
date: 2016-03-12
changes:
- Updated tiny-lr, gaze, async and lodash dependencies.
- Fix endless loop issue with atBegin/nospawn.
- Expose hostname parameter of tiny-lr.
- Support cwd.event to emit events relative to path.
- Removed peerDependencies setting.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Dec 7, 2018
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-watch-1.1.0 branch from 17ac986 to b8fbc7b Compare December 7, 2018 16:59
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-watch-1.1.0 branch from b8fbc7b to d3bd289 Compare January 1, 2019 21:12
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-watch-1.1.0 branch from d3bd289 to 3f6a192 Compare January 1, 2019 21:16
@ghost ghost assigned jywarren Jan 1, 2019
@ghost ghost added the in progress label Jan 1, 2019
@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

Tested locally!

@jywarren jywarren merged commit db87510 into master Jan 1, 2019
@ghost ghost removed the in progress label Jan 1, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/grunt-contrib-watch-1.1.0 branch January 1, 2019 21:52
@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

Hi @greysteil please don't read this on New Year's Day but once you're back online, i was wondering if the extra merge commit here invalidates this PR from contributing to the compatibility score? The auto-rebase is really nice, but the rate that node module updates come in is so fast, we've seen it as a bottleneck in merging updates in a node environment. Each merge has to trigger like 8 other PRs to be rebased. So I tried just merging using the GitHub interface here to save time.

Any tips on the super-fast-moving node environment? We've had trouble keeping up. Also, noting #196 where many node module updates don't affect our src tests, but do affect our build/compile process, which isn't itself tested. We're planning to add tests to confirm that our build process is tested, but it's starting to seem a bit meta... any thoughts on that issue?

@greysteil
Copy link

Hey, sorry for the slow reply on this one - I did read it on New Year's Day, but didn't reply as I needed the break! 🙂

Good question. A couple of things:

  • Adding a merge commit will stop @dependabot rebase from working, but you can use @dependabot recreate instead, so it shouldn't cause too many issues
  • I think we can improve the way Dependabot does rebases when there are multiple PRs open. Specifically, I'm thinking about adding an option where it only rebases one-by-one, so there's less CI load at any one time, and if you have automerge enabled, or are merging the PRs manually as you go, in total there are fewer CI runs.

What do you reckon?

@jywarren
Copy link
Member

jywarren commented Jan 10, 2019 via email

@jywarren
Copy link
Member

jywarren commented Jan 10, 2019 via email

@greysteil
Copy link

I think that's a good suggestion. I'm a little underwater right now, but will try to get a rebase and merge option added when things calm down! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants