Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testing cover the build process "grunt build" #196

Closed
jywarren opened this issue Jan 1, 2019 · 1 comment · Fixed by #206
Closed

Make testing cover the build process "grunt build" #196

jywarren opened this issue Jan 1, 2019 · 1 comment · Fixed by #206
Assignees
@rexagod
Labels
help wanted testing

Comments

@jywarren
Copy link
Member

jywarren commented Jan 1, 2019

This will help address #195

We need to get our tests to run grunt test and pass only if that completes. Then we'll be able to more confidently merge @dependabot updates that address build code such as Browserify in #163.

@rexagod would you have any interest in trying to get this working? I think it'd be an adjustment to the Gruntfile. We'd want to first confirm that a failed build results in Travis reporting a build failure.

Thanks!!!
@jywarren jywarren mentioned this issue Jan 1, 2019
Merged
@rexagod rexagod mentioned this issue Jan 4, 2019
Closed
rexagod added a commit to rexagod/PublicLab.Editor that referenced this issue Jan 5, 2019
@rexagod
PL.Editor publiclab#196
2339ffd
@rexagod rexagod mentioned this issue Jan 5, 2019
Merged
5 tasks
@ghost ghost assigned rexagod Jan 5, 2019
@ghost ghost added the in progress label Jan 5, 2019
@rexagod
Copy link
Member

rexagod commented Jan 5, 2019 •
edited
Loading

Failed build now results in a "failed" prompt

jywarren pushed a commit that referenced this issue Jan 7, 2019
@rexagod @jywarren
Incorporate build in ci (#206)
1c34097 
* PL.Editor #196

* PL.Editor #206 refactored
@ghost ghost removed the in progress label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rexagod rexagod

Labels
help wanted testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Incorporate build in ci rexagod/PublicLab.Editor
2 participants
@jywarren @rexagod