-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate build in ci #206
Conversation
Oh cool! Can you demonstrate that it breaks the Travis build if grunt build fails? Maybe... by removing one of the npm packages that build depends on? (we can revert the commit once demonstrated, just want to be sure!) Thanks so much, this is great! |
…into rexagod_specs1
@jywarren Sure, although the current travis configuration fails if build does (as is shown here), I did notice there was a chance to refactor the yml and went with it instead, hence making some the necessary changes. Normal run: https://travis-ci.org/publiclab/PublicLab.Editor/builds/476030956 |
Awesome. Merging this! Would you be interested in adding this to a number of our other JS repositories? These could all use it; we could mention this in the weekly Check-In to recommend others make this change if you don't want to do all yourself?
|
Sure! I'll do it. |
Fixes #196 --> https://travis-ci.org/publiclab/PublicLab.Editor/jobs/475590529#
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!