Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate build in ci #206

Merged
merged 6 commits into from
Jan 7, 2019
Merged

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jan 5, 2019

Fixes #196 --> https://travis-ci.org/publiclab/PublicLab.Editor/jobs/475590529#

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned rexagod Jan 5, 2019
@ghost ghost added the in progress label Jan 5, 2019
@rexagod rexagod requested a review from jywarren January 6, 2019 00:26
@jywarren
Copy link
Member

jywarren commented Jan 6, 2019

Oh cool! Can you demonstrate that it breaks the Travis build if grunt build fails? Maybe... by removing one of the npm packages that build depends on? (we can revert the commit once demonstrated, just want to be sure!)

Thanks so much, this is great!

@rexagod
Copy link
Member Author

rexagod commented Jan 6, 2019

@jywarren Sure, although the current travis configuration fails if build does (as is shown here), I did notice there was a chance to refactor the yml and went with it instead, hence making some the necessary changes.

Normal run: https://travis-ci.org/publiclab/PublicLab.Editor/builds/476030956
Failed run after grunt-browserify was removed: https://travis-ci.org/publiclab/PublicLab.Editor/builds/476031041

@jywarren
Copy link
Member

jywarren commented Jan 7, 2019

Local Npm module "grunt-browserify" not found. Is it installed?

Awesome. Merging this! Would you be interested in adding this to a number of our other JS repositories? These could all use it; we could mention this in the weekly Check-In to recommend others make this change if you don't want to do all yourself?

@rexagod
Copy link
Member Author

rexagod commented Jan 9, 2019

Sure! I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make testing cover the build process "grunt build"
2 participants