Compilation of ui js files

[Mridul97]

Issue #598

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[jywarren]

Cool! Would you want to try refactoring this to use require() and browserify as well? Or shall we do that in a follow-up PR? That way we can easily include files into each other and such, as well as test them more modularly.

[jywarren]

And great work!!!

[Mridul97]

@jywarren I would like to refactor this to use require() and browserify. I think we can do it in a follow-up PR, will open one soon! Thanks :)

[jywarren]

oh ok! I'm not sure if this will conflict with #562 but I want to merge that first. Thanks, then will merge this.

[harshkhandeparkar]

@jywarren @Mridul97 i think image-sequencer.js is included in the ui. Can we include the minified file in the minified ui files?

[jywarren]

So, I don't think we need to include the base library into the UI. We can assume it's there, for now. When we write tests, we may have to include it into the fixture files, as we do in tests for HTML driven code like this: https://github.com/publiclab/PublicLab.Editor/tree/master/spec/javascripts

For now, I think we can just compile demo.js and everything in /examples/lib/ into a single file. We may need to restructure how they fit together using module.exports and such. If you'd like to make an initial attempt I can provide some support, thanks!

[jywarren]

Hi, I think this is good but perhaps we could integrate this cool idea of having the build process be included in the Travis checks: publiclab/PublicLab.Editor#206

That way we will at least know if the compilation succeeds. How does that sound? Thanks!

[jywarren]

Oh wait, sorry, grunt build is already in the tests! Awesome! Then I think this is good for now. Next up is require()!