Fixed Save Button

[harshkhandeparkar]

Fixes #340

Save button gets enabled whenever there is a change in the value of the input.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[harshkhandeparkar]

@tech4GT please have a look at this.

[harshkhandeparkar]

Sorry for the update dist extra commit, I somehow screwed up my local dist files and had to squash some commits.

[harshkhandeparkar]

I found out an issue. This doesn't work for select type input, the initial value is different and changes after some time.

[harshkhandeparkar]

It also didn't use to update the initValue so saving more than once would break the save buttons. But this is fixed now in 'fix update initValue' commit. Select is still an issue though.

[harshkhandeparkar]

Update: I fixed the select type inputs by moving the event listeners to the end of onComplete function.

[harshkhandeparkar]

[harshkhandeparkar]

@tech4GT I have a suggestion, Can you open a new issue to change all the module inputs types to match their actual html valid types. For e.g. angle for rotate module is 'integer' but it should be number so that increment and decrement buttons appear on pc browsers. Also for modules like resize the percentage is a 'string' not text.

[tech4GT]

@harshkhandeparkar You can go ahead and open the issue, that'll be great! Also can you please share a gif using some module which takes text based input like saturation? Thanks! :)

[harshkhandeparkar]

Text-based input:

I tried changing the field type to number but it only gives string type input. For number type inputs, 0.2 and 0.20 are actually considered as different even though they are not.

[harshkhandeparkar]

I actually fixed this. Committing in a min

[harshkhandeparkar]

Fix:

[harshkhandeparkar]

Hey I found something else. The form can be submitted through enter even though the button is disabled.

[harshkhandeparkar]

Please don't merge this PR. I'm going to fix the enter button submit issue. I'm going to be busy for a few days. Will fix this next year 😋

[harshkhandeparkar]

I had to add the e.preventDefault() since the form reloads the page on submitting by default and adds some useless get methods to the URL.

[harshkhandeparkar]

[harshkhandeparkar]

[harshkhandeparkar]

This solution works but I noticed that it slows down the browser significantly. What should I do?. @publiclab/reviewers please help.

[harshkhandeparkar]

@tech4GT @jywarren please have a look. Also I wanted to ask if ES6 features like arrow functions and template literals can be used in the example page code?

[harshkhandeparkar]

Everything still works:

Range ✔️

This ⬆️ ⬆️ works even better than earlier 🎉 🎉

Multi-Input ✔️

Select ✔️

Number ✔️

[harshkhandeparkar]

@jywarren @tech4GT please have a look.

[harshkhandeparkar]

@tech4GT @jywarren I have an idea. Can we add a new module which takes text as input and adds a qr code to any place in the image like at the corners etc. Maybe to make a photo with a link or something?

[harshkhandeparkar]

@jywarren can we use es6 in the example page code?

[jywarren]

What browsers is es6 compliant in? If almost all, then sure, but if there's an easy alternative, maybe not?

[harshkhandeparkar]

I think arrow functions and template literals are supported by all modern(>IE) browsers. https://kangax.github.io/compat-table/es6/

…

On Mon 7 Jan, 2019, 12:05 AM Jeffrey Warren ***@***.*** wrote: What browsers is es6 compliant in? If almost all, then sure, but if there's an easy alternative, maybe not? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#562 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhKOn8mwVZj7f8s29Ohowj5EaQTj8Na6ks5vAkHbgaJpZM4Zi5Br> .

[harshkhandeparkar]

@jywarren @tech4GT please review this.

[harshkhandeparkar]

@jywarren @tech4GT I have resolved conflicts please review. Also please look at my suggestion above 👆👆

[jywarren]

Hi, this is great. I'd like one more person to review it if possible -- maybe @Mridul97 ? Also be aware I'd like to merge this before #627, but after that one we may be able to start adding UI tests, which would be great to preserve and maintain these complex UI interactions. Great work!

[harshkhandeparkar]

Thanks.

[harshkhandeparkar]

@jywarren how is my suggestion about a new module above 👆 👆

[jywarren]

Hi, sure - perhaps you could open a new issue for that? it could be called add-qr

[harshkhandeparkar]

Hi, sure - perhaps you could open a new issue for that? it could be called add-qr

Thanks for the green signal. I will open the issue tomorrow.

[Mridul97]

This looks good to me. Great work! :)

[harshkhandeparkar]

Thanks @Mridul97

[jywarren]

Awesome, thank you!!!

[harshkhandeparkar]

Thanks @jywarren
I think #377 also should be closed?