fixing various error occuring during testing (some related to window keyword, some gl-context/puppeteer) #1285

keshav234156 · 2019-10-28T18:58:06Z

A lot errors(reference errors,type errors,Unhandled 'error' events,WebAssembly acceleration error) could be seen in travis logs.this could be seen in https://travis-ci.org/publiclab/image-sequencer/jobs/595161585?utm_medium=notification&utm_source=github_status .These errors our preventing us to completly test our module ie all the individual modules are not being tested.Some of these errors have occured after merging PR #1234 (as all the individual modules were tested before this in #1233 travis logs. )

keshav234156 · 2019-10-28T18:58:49Z

cc: @jywarren @vaibhavmatta

keshav234156 · 2019-10-28T19:26:43Z

@jywarren we have faced similar issue as mentioned in #659 #1113.

jywarren · 2019-10-28T19:43:54Z

Is there anything you all can see particularly linking the mixin-deep module that was upgraded in #1234 to the errors not triggering a failed build, do you think?

Also cc'ing @aashna27 @harshkhandeparkar @harshithpabbati @tech4GT @Divy123 in case you all have insights here. Thanks! Testing and stabilizing our tests will do a huge amount to strengthen the core of our code!

keshav234156 · 2019-10-28T19:47:33Z

right now No, i think it's just because of upgrade in version of mixing-deep

jywarren · 2019-10-28T19:52:25Z

We could test this by opening a PR rolling back the version and seeing if the tests run correctly?

…

On Mon, Oct 28, 2019, 3:48 PM keshav234156 ***@***.***> wrote: No i think it's because of upgrade in version of mixing-deep — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1285?email_source=notifications&email_token=AAAF6J26E63IKLQKDP3LMF3QQ46VLA5CNFSM4JF6SB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECOFEQA#issuecomment-547115584>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J236AYAXCLQ62NJX6TQQ46VLANCNFSM4JF6SB2Q> .

keshav234156 · 2019-10-28T20:25:55Z

@jywarren reverting the changes of #1234 in #1286 didn't work.

jywarren · 2019-10-29T18:49:07Z

Hmm. is the next step to try to get the failing tests to cause Travis to return a failure?

vaibhavmatta · 2019-10-29T18:50:48Z

@jywarren I was about to suggest that!

keshav234156 · 2019-11-02T11:44:13Z

@jywarren So the problem is with PR #1090. After reverting the changes of #1090(as done in #1289) the modules that are preventing all modules to being tested are:

1.fisheye-gl
2.text-overlay.
3.webgl-distort.

only after soving errors related to the above mentioned modules we would be able to test are modules completely.

Next we should try to fix the errors that are found in modules.These modules include :
1.colorbar
2.draw-rectangle
3.gamma-correction
4.paint-bucket
5.replace-color
6.rotate module
7.tint module

jywarren · 2019-11-02T18:36:25Z

Oh wow! So, wait, can you clarify... const $ = window.$; caused the error. When we remove that, these modules then error out?

1.fisheye-gl
2.text-overlay.
3.webgl-distort.

Do they need this $ const defined? We could potentially run that line only if we're in a specific environment where window is defined, maybe?
Then, are you saying, more errors have accumulated in these other modules since then, and we can circle back in and resolve those?
Finally, should we have trusted the change in coverage reported there, and rejected that PR?

Thank you so much for this excellent detective work!!!!

keshav234156 · 2019-11-02T19:17:54Z

@jywarren
1.You are right window is only defined in browser environment but is not defined in node.js environment. so they causing errors.similar errors could be seen with fisheye-gl,text-overlay,webgl-distort so we have fix it as well
2.yes,many errors have been accumulated since then as are modules where not being test.these include 7 modules that i have listed above.
3.we should have trusted the coverage report as coverage was decreased by a large amount with the PR.

jywarren · 2019-11-04T21:03:59Z

Uh ok - so i believe there is a way we can see if we're in a browser environment, but i'm a little rusty. It could be either options.inBrowser or typeof window == 'undefined'?

keshav234156 · 2019-11-30T12:27:57Z

@jywarren after merging #1289 , our next step should be to solve the error as given in the below error logs.Do you have any idea how can we solve this?

/home/keshav/image-sequencer/node_modules/fisheyegl/src/fisheyegl.js:304
  window.FisheyeGl = FisheyeGl;
  ^

ReferenceError: window is not defined
    at Object.<anonymous> (/home/keshav/image-sequencer/node_modules/fisheyegl/src/fisheyegl.js:304:3)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Module.replacementCompile (/home/keshav/image-sequencer/node_modules/append-transform/index.js:58:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Object.<anonymous> (/home/keshav/image-sequencer/node_modules/append-transform/index.js:62:4)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Array.DoNothing (/home/keshav/image-sequencer/src/modules/FisheyeGl/Module.js:1:5010)
    at insertStep (/home/keshav/image-sequencer/src/InsertStep.js:1:8350)
    at InsertStep (/home/keshav/image-sequencer/src/InsertStep.js:1:8500)
    at AddStep (/home/keshav/image-sequencer/src/AddStep.js:1:1000)
    at Object.addSteps (/home/keshav/image-sequencer/src/ImageSequencer.js:1:27737)
    at Test.t (/home/keshav/image-sequencer/test/core/templates/module-test.js:23:15)

jywarren · 2019-12-02T16:08:56Z

This last error happens because it's designed for use in a browser -- which has the variable window. But in nodejs this doesn't exist. I'm not sure, i think we can use this syntax to skip this when in node?

image-sequencer/src/ImageSequencer.js

Line 1 in f1c94fd

if (typeof window !== 'undefined') { isBrowser = true; }

keshav234156 · 2019-12-03T19:38:16Z

@jywarren ok,I added the following the lines of code in the test file

const { JSDOM } = require('jsdom');
var { window } = new JSDOM();

adding this error logs where

fisheye-gl module loads correctly

✔ fisheye-gl module is getting loaded

fisheye-gl module loads with correct options

✔ Option a is correct
✔ Option b is correct
✔ Option Fx is correct
✔ Option Fy is correct
✔ Option scale is correct
✔ Option x is correct
✔ Option y is correct

fisheye-gl module works correctly

(node:25070) UnhandledPromiseRejectionWarning: Error: Evaluation failed: ReferenceError: __cov_7dJRRx77$AD_iFr6aR7E3A is not defined
    at __puppeteer_evaluation_script__:1:12
    at ExecutionContext._evaluateInternal (/home/keshav/image-sequencer/node_modules/puppeteer/lib/ExecutionContext.js:122:13)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  -- ASYNC --
    at ExecutionContext.<anonymous> (/home/keshav/image-sequencer/node_modules/puppeteer/lib/helper.js:111:15)
    at DOMWorld.evaluate (/home/keshav/image-sequencer/node_modules/puppeteer/lib/DOMWorld.js:112:20)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  -- ASYNC --
    at Frame.<anonymous> (/home/keshav/image-sequencer/node_modules/puppeteer/lib/helper.js:111:15)
    at Page.evaluate (/home/keshav/image-sequencer/node_modules/puppeteer/lib/Page.js:827:43)
    at Page.<anonymous> (/home/keshav/image-sequencer/node_modules/puppeteer/lib/helper.js:112:23)
    at page.addScriptTag.then (/home/keshav/image-sequencer/src/modules/_nomodule/gl-context.js:9:992)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:25070) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

So now we can test that the module loads correctly with the correct option. Do you know, why the error is occurring in the works correctly part?

jywarren · 2019-12-03T20:40:39Z

This is some great progress!!! Awesome!!! I don't know what this error is about, but maybe @Divy123 or @harshkhandeparkar or others from @publiclab/is-reviewers or @publiclab/image-sequencer-guides knows?

jywarren · 2019-12-03T20:41:20Z

Perhaps we should merge what we have so far here, and work on the remainder in a fresh issue? To build on the great progress you've made so far!?

keshav234156 · 2019-12-03T21:06:47Z

Ok, found that error is occurring as we are using gl-context which in turn is using puppeteer. It is a Code Transpilation Issues ie If you are using a JavaScript transpiler like babel or TypeScript, calling evaluate() with an async function might not work. This is because while puppeteer uses Function.prototype.toString() to serialize functions while transpilers could be changing the output code in such a way it's incompatible with the puppeteer.

also before the PR #1007, we were not using gl-context, so the test worked for them

jywarren · 2019-12-03T21:14:01Z

whoa, excellent investigating!

…

On Tue, Dec 3, 2019 at 4:07 PM keshav234156 ***@***.***> wrote: Ok, found that error is occurring as we gl-context which in turn is using puppeteer. It is a Code Transpilation Issues ie If you are using a JavaScript transpiler like babel or TypeScript, calling evaluate() with an async function might not work. This is because while puppeteer uses Function.prototype.toString() to serialize functions while transpilers could be changing the output code in such a way it's incompatible with the puppeteer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1285?email_source=notifications&email_token=AAAF6JYZYKUEAKY7B2MKDZTQW3C6RA5CNFSM4JF6SB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF22BUI#issuecomment-561357009>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J3K5A6WCAN4XE7XRZDQW3C6RANCNFSM4JF6SB2Q> .

keshav234156 · 2019-12-10T17:00:18Z

our next step should be fix 7 modules.For that, i found the module was changed as it has some bugs like the rotate module was earlier having fixed dimension but corresponding benchmarks were not changed as a result they are failing. So for this, we can change the benchmarks of those modules. Then our next step should be if there is any failure in the test then Travis should raise an error rather than passing it

SidharthBansal · 2019-12-10T18:26:25Z

I think you guys will teach me IS this GCI.

SidharthBansal · 2019-12-10T18:27:01Z

My inbox has more IS emails than other repos and I am reviewing some PRs too. :-) 🚀

jywarren · 2019-12-10T18:33:27Z

:-) thanks for being on top of this, Sidharth!!!!

…

On Tue, Dec 10, 2019 at 1:27 PM Sidharth Bansal ***@***.***> wrote: My inbox has more IS emails than other repos and I am reviewing some PRs too. :-) 🚀 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1285?email_source=notifications&email_token=AAAF6J4WAGOJ2RYGVFMNAYLQX7NPNA5CNFSM4JF6SB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGQIKWQ#issuecomment-564168026>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J2P44DTP3S2OGYL6LDQX7NPNANCNFSM4JF6SB2Q> .

keshav234156 · 2019-12-19T19:13:09Z

#1376 #1377 #1378

jywarren · 2020-07-12T19:47:13Z

I'm closing this in favor of the now narrowed #1378! Thanks!

keshav234156 mentioned this issue Oct 28, 2019

fixes ES6 failure in tests #1269

Open

5 tasks

keshav234156 added the high-priority label Oct 28, 2019

jywarren added discussion help wanted help wanted testing labels Oct 28, 2019

keshav234156 mentioned this issue Dec 6, 2019

Fixes some of the test #1330

Merged

harshkhandeparkar removed the help wanted label Jan 12, 2020

jywarren changed the title ~~fixing various error occuring during testing~~ fixing various error occuring during testing (some related to window keyword, some gl-context/puppeteer) Jul 12, 2020

jywarren closed this as completed Jul 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixing various error occuring during testing (some related to window keyword, some gl-context/puppeteer) #1285

fixing various error occuring during testing (some related to window keyword, some gl-context/puppeteer) #1285

keshav234156 commented Oct 28, 2019

keshav234156 commented Oct 28, 2019 •

edited

Loading

keshav234156 commented Oct 28, 2019 •

edited

Loading

jywarren commented Oct 28, 2019

keshav234156 commented Oct 28, 2019 •

edited

Loading

jywarren commented Oct 28, 2019 via email

keshav234156 commented Oct 28, 2019

jywarren commented Oct 29, 2019

vaibhavmatta commented Oct 29, 2019

keshav234156 commented Nov 2, 2019

jywarren commented Nov 2, 2019

keshav234156 commented Nov 2, 2019

jywarren commented Nov 4, 2019

keshav234156 commented Nov 30, 2019

jywarren commented Dec 2, 2019

keshav234156 commented Dec 3, 2019 •

edited

Loading

jywarren commented Dec 3, 2019

jywarren commented Dec 3, 2019

keshav234156 commented Dec 3, 2019 •

edited

Loading

jywarren commented Dec 3, 2019 via email

keshav234156 commented Dec 10, 2019

SidharthBansal commented Dec 10, 2019

SidharthBansal commented Dec 10, 2019

jywarren commented Dec 10, 2019 via email

keshav234156 commented Dec 19, 2019

jywarren commented Jul 12, 2020

fixing various error occuring during testing (some related to window keyword, some gl-context/puppeteer) #1285

fixing various error occuring during testing (some related to window keyword, some gl-context/puppeteer) #1285

Comments

keshav234156 commented Oct 28, 2019

keshav234156 commented Oct 28, 2019 • edited Loading

keshav234156 commented Oct 28, 2019 • edited Loading

jywarren commented Oct 28, 2019

keshav234156 commented Oct 28, 2019 • edited Loading

jywarren commented Oct 28, 2019 via email

keshav234156 commented Oct 28, 2019

jywarren commented Oct 29, 2019

vaibhavmatta commented Oct 29, 2019

keshav234156 commented Nov 2, 2019

jywarren commented Nov 2, 2019

keshav234156 commented Nov 2, 2019

jywarren commented Nov 4, 2019

keshav234156 commented Nov 30, 2019

jywarren commented Dec 2, 2019

keshav234156 commented Dec 3, 2019 • edited Loading

jywarren commented Dec 3, 2019

jywarren commented Dec 3, 2019

keshav234156 commented Dec 3, 2019 • edited Loading

jywarren commented Dec 3, 2019 via email

keshav234156 commented Dec 10, 2019

SidharthBansal commented Dec 10, 2019

SidharthBansal commented Dec 10, 2019

jywarren commented Dec 10, 2019 via email

keshav234156 commented Dec 19, 2019

jywarren commented Jul 12, 2020

keshav234156 commented Oct 28, 2019 •

edited

Loading

keshav234156 commented Oct 28, 2019 •

edited

Loading

keshav234156 commented Oct 28, 2019 •

edited

Loading

keshav234156 commented Dec 3, 2019 •

edited

Loading

keshav234156 commented Dec 3, 2019 •

edited

Loading