-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Module.js #1090
Update Module.js #1090
Conversation
Added const $ = window.$; at line 19 inside extraManipulation(pixels)
Codecov Report
@@ Coverage Diff @@
## main #1090 +/- ##
===========================================
- Coverage 55.11% 32.07% -23.05%
===========================================
Files 117 107 -10
Lines 2344 1986 -358
Branches 360 297 -63
===========================================
- Hits 1292 637 -655
- Misses 1052 1349 +297
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thank you!!! |
This reverts commit 3741d67.
Added const $ = window.$; at line 19 inside extraManipulation(pixels)
Added const $ = window.$; at line 19 inside extraManipulation(pixels)
Fixes #0000 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!